From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759274AbbJ3JMU (ORCPT ); Fri, 30 Oct 2015 05:12:20 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54958 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758333AbbJ3JMQ convert rfc822-to-8bit (ORCPT ); Fri, 30 Oct 2015 05:12:16 -0400 X-AuditID: cbfee690-f794e6d0000014de-d1-5633346e028e MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <5633346E.8040208@samsung.com> Date: Fri, 30 Oct 2015 18:12:14 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Sangbeom Kim , Lee Jones , Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children References: <1446191481-21214-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1446191481-21214-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRsSkQDfPxDjM4PMJK4s3b9cwWbx+YWhx /+tRRovLu+awWcw4v4/J4uKKL0wObB53ru1h89jSf5fdo2/LKkaPz5vkAliiuGxSUnMyy1KL 9O0SuDJ+rOhhK7jPW9F9Wq6BsYW7i5GTQ0LARGLi4jZGCFtM4sK99WxdjFwcQgIrGCUWr9zO BlN0889GFojELEaJhbfbWEASvAKCEj8m3wOzmQXUJSbNW8TcxcgBZItIPJ/iBBHWlli28DUz RO8DRon2L6fZIXq1JDpaNoItYBFQlfj+9QhYnA0ovv/FDTaQOaICERLdJypBekUEPjJK/Jrw igkkLgwUv35fBaRcSMBd4kzLL7ATOAU8JC5MWcAOUi8hsI1dYsL6eVDzBSS+TT7EAtIrISAr sekAM8RfkhIHV9xgmcAoNgvJN7OQfDML4ZtZSL5ZwMiyilE0tSC5oDgpvchErzgxt7g0L10v OT93EyMw5k7/ezZhB+O9A9aHGAU4GJV4eAOSjcKEWBPLiitzDzGaAh00kVlKNDkfGNl5JfGG xmZGFqYmpsZG5pZmSuK8r6V+BgsJpCeWpGanphakFsUXleakFh9iZOLglGpgrNzj6ab2aPnT LB/jS915tj9Ckp/WyS6yOlwj714q+NFftL847nnMpAnV98+H3r98aZeDbGf1S4XN+XPPnTnD UFE8ISSGNXWme7CGt/WzXcG8hzveH/su8OUwbzq7cLTsRp+E839Mj23dGhFYZReffkPhtvcq 5Vn709jL5CK9nTg116zr2XhJiaU4I9FQi7moOBEAsuVsrLQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jQd08E+MwgxP/TSzevF3DZPH6haHF /a9HGS0u75rDZjHj/D4mi4srvjA5sHncubaHzWNL/112j74tqxg9Pm+SC2CJamC0yUhNTEkt UkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAFarqRQlphTChQKSCwu VtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMePPmIXvBft6KroZe5gbGJ1xdjJwcEgImEjf/ bGSBsMUkLtxbz9bFyMUhJDCLUWLh7TawBK+AoMSPyfeAbA4OZgF5iSOXskHCzALqEpPmLWKG qH/AKNH+5TQ7RL2WREfLRjYQm0VAVeL71yNgcTag+P4XN9hA5ogKREh0n6gE6RUR+Mgo8WvC KyaQuDBQ/Pp9FZByIQF3iTMtv8BO4BTwkLgwZQH7BEb+WUgumoVw0SwkFy1gZF7FKJFakFxQ nJSea5iXWq5XnJhbXJqXrpecn7uJERypz6R2MB7c5X6IUYCDUYmH90eCUZgQa2JZcWXuIUYJ DmYlEd53CsZhQrwpiZVVqUX58UWlOanFhxhNgV6ayCwlmpwPTCJ5JfGGxiZmRpZG5oYWRsbm SuK8+p5AcwTSE0tSs1NTC1KLYPqYODilGhizRNOkJmT0/M9u0bLs2N/4+XUot88Mv9hPxh6S C649//jFc8bRMj+hko03mt8qXtttcDRS9LPFrua0f39uihX0Cj1cJzAjeNLq2OWdj3gj2TY9 n8P9Jn9FVYp3yG/unJAL2esqdhj/KTbay1x5uuPU5iA3Xf+88DMz3hTzvX7eEtnSsfXtlVol luKMREMt5qLiRADmAbaa6gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015년 10월 30일 16:51, Krzysztof Kozlowski wrote: > The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 > device") added new MFD child devices for S2MPU02: RTC and clock > provider (the clock provider with new compatible). However support for > these devices was not added to existing drivers (rtc-s5m, clk-s2mps11). > New drivers were not submitted neither. > > This means that the name of children devices is completely unused. The > "samsung,s2mpu02-clk" compatible remains undocumented so it is unclear > what is provided by that compatible. > > Clean up this by removing unused child devices and undocumented > compatible. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I don't think that removing the "samsung,s2mpu02-clk" compatible would > be considered as ABI break because: > 1. Kernel did not document it as ABI. > 2. Kernel did not provide any kind of feature for that compatible. It > was totally ignored. > --- > drivers/mfd/sec-core.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 2626fc0b5b8c..989076d6cb83 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -103,12 +103,9 @@ static const struct mfd_cell s2mpa01_devs[] = { > }; > > static const struct mfd_cell s2mpu02_devs[] = { > - { .name = "s2mpu02-pmic", }, > - { .name = "s2mpu02-rtc", }, > { > - .name = "s2mpu02-clk", > - .of_compatible = "samsung,s2mpu02-clk", > - } > + .name = "s2mpu02-pmic", > + }, > }; > > #ifdef CONFIG_OF > Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi