From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759134AbbJ3OfW (ORCPT ); Fri, 30 Oct 2015 10:35:22 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:36394 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758766AbbJ3OfU (ORCPT ); Fri, 30 Oct 2015 10:35:20 -0400 Subject: Re: [PATCH 1/3] recordmcount: fix endianness handling bug for nop_mcount To: Li Bin , will.deacon@arm.com, lkp@intel.com, catalin.marinas@arm.com, rostedt@goodmis.org, takahiro.akashi@linaro.org References: <1446193864-24593-1-git-send-email-huawei.libin@huawei.com> <1446193864-24593-2-git-send-email-huawei.libin@huawei.com> Cc: zhouchengming1@huawei.com, xiexiuqi@huawei.com, guohanjun@huawei.com, linux-kernel@vger.kernel.org, dingtianhong@huawei.com, linux-arm-kernel@lists.infradead.org From: Sergei Shtylyov Message-ID: <56338025.3060602@cogentembedded.com> Date: Fri, 30 Oct 2015 17:35:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446193864-24593-2-git-send-email-huawei.libin@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/30/2015 11:31 AM, Li Bin wrote: > In nop_mcount, shdr->sh_offset and welp->r_offset should handle > endianness properly, otherwise it will trigger Segmentation fault > if the recordmcount main and file.o have different endianness. > > Cc: # 3.0+ > Signed-off-by: Li Bin > --- > scripts/recordmcount.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h > index 49b582a..dda9dba 100644 > --- a/scripts/recordmcount.h > +++ b/scripts/recordmcount.h > @@ -376,8 +376,9 @@ static void nop_mcount(Elf_Shdr const *const relhdr, > mcountsym = get_mcountsym(sym0, relp, str0); > > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) { > - if (make_nop) > - ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset); > + if (make_nop) { > + ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset)); > + } {} not needed here. MBR, Sergei