From: santosh shilimkar <santosh.shilimkar@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ssantosh@kernel.org
Subject: Re: [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable
Date: Fri, 30 Oct 2015 08:50:14 -0700 [thread overview]
Message-ID: <563391B6.80006@oracle.com> (raw)
In-Reply-To: <20151030.201536.285461609251750460.davem@davemloft.net>
On 10/30/2015 4:15 AM, David Miller wrote:
> From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Date: Wed, 28 Oct 2015 15:51:12 -0700
>
>> + &rs->rs_bound_node, ht_parms)) {
>> *port = rs->rs_bound_port;
>> ret = 0;
>> rdsdebug("rs %p binding to %pI4:%d\n",
>> rs, &addr, (int)ntohs(*port));
>> break;
>> } else {
>> - rds_sock_put(rrs);
>> + rds_sock_put(rs);
>> + ret = -ENOMEM;
>> + break;
>> }
>> +
>> } while (rover++ != last);
>>
>> return ret;
>
> This final insert of an empty line is both inappropriate and even
> if it was it would not be related to this change.
>
Right. I just posted v2, dropping the empty line. Thanks !!
Regards,
Santosh
prev parent reply other threads:[~2015-10-30 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 22:51 [net-next PATCH] RDS: convert bind hash table to re-sizable hashtable Santosh Shilimkar
2015-10-30 11:15 ` David Miller
2015-10-30 15:50 ` santosh shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563391B6.80006@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox