From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932805AbbJ3Pu1 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 30 Oct 2015 11:50:27 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:20066 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759804AbbJ3PuZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 30 Oct 2015 11:50:25 -0400
Subject: Re: [net-next PATCH] RDS: convert bind hash table to re-sizable
 hashtable
To: David Miller <davem@davemloft.net>
References: <1446072672-4325-1-git-send-email-santosh.shilimkar@oracle.com>
 <20151030.201536.285461609251750460.davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ssantosh@kernel.org
From: santosh shilimkar <santosh.shilimkar@oracle.com>
Organization: Oracle Corporation
Message-ID: <563391B6.80006@oracle.com>
Date: Fri, 30 Oct 2015 08:50:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151030.201536.285461609251750460.davem@davemloft.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/30/2015 4:15 AM, David Miller wrote:
> From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Date: Wed, 28 Oct 2015 15:51:12 -0700
>
>> +					    &rs->rs_bound_node, ht_parms)) {
>>   			*port = rs->rs_bound_port;
>>   			ret = 0;
>>   			rdsdebug("rs %p binding to %pI4:%d\n",
>>   			  rs, &addr, (int)ntohs(*port));
>>   			break;
>>   		} else {
>> -			rds_sock_put(rrs);
>> +			rds_sock_put(rs);
>> +			ret = -ENOMEM;
>> +			break;
>>   		}
>> +
>>   	} while (rover++ != last);
>>
>>   	return ret;
>
> This final insert of an empty line is both inappropriate and even
> if it was it would not be related to this change.
>
Right. I just posted v2, dropping the empty line. Thanks !!

Regards,
Santosh