From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759819AbbJ3TVS (ORCPT ); Fri, 30 Oct 2015 15:21:18 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:34897 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752636AbbJ3TVR (ORCPT ); Fri, 30 Oct 2015 15:21:17 -0400 Subject: Re: [PATCH v5 1/5] Documentation: tps65912: Add DT bindings for the TPS65912 PMIC To: Lee Jones References: <1446161922-8755-1-git-send-email-afd@ti.com> <1446161922-8755-2-git-send-email-afd@ti.com> <20151030171006.GZ4058@x1> <5633B078.7080209@ti.com> <20151030190622.GN4058@x1> CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Alexandre Courbot , Samuel Ortiz , Liam Girdwood , Mark Brown , , , From: "Andrew F. Davis" Message-ID: <5633C31E.5030408@ti.com> Date: Fri, 30 Oct 2015 14:21:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151030190622.GN4058@x1> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 02:06 PM, Lee Jones wrote: > On Fri, 30 Oct 2015, Andrew F. Davis wrote: > >> On 10/30/2015 12:10 PM, Lee Jones wrote: >>> On Thu, 29 Oct 2015, Andrew F. Davis wrote: >>> >>>> The TPS65912 PMIC contains several regulators and a GPIO controller. >>>> Add bindings for the TPS65912 PMIC. >>>> >>>> Signed-off-by: Andrew F. Davis >>>> --- >>>> .../devicetree/bindings/gpio/gpio-tps65912.txt | 16 +++++++ >>> >>> Why have you dropped Linus' Review-by? >>> >> >> Strange, I thought I made a change to this. Well this brings up a question, >> how much change can we have before we are supposed to drop Reviewed/Acked-by? > > Common sense call I'm afraid. ;) > > [...] > >>>> + the second cell is used to specify flags. >>>> + See include/dt-bindings/gpio/gpio.h for possible values. >>> >>> This is a Linuxisum and shouldn't really live in here. >>> >>> I think it would be better to document them in ../gpio/gpio.txt and >>> reference that instead. >>> >> >> Looks like that is already in ../gpio/gpio.txt:57 > > There is a mention of GPIO_ACTIVE_HIGH, as it's used in an example. > However GPIO_ACTIVE_LOW is missing. I think both could do with > documenting properly, then you can refer to them from here. > I mean the lines above the example, they say to use the macros defined in include/dt-bindings/gpio/gpio.h whenever possible, that's really all I would say. > [...] > >>>> +Required properties: >>>> + - compatible : Should be "ti,tps65912". >>>> + - reg : Slave address or chip select number (I2C / SPI). >>>> + - interrupt-parent : The parent interrupt controller. >>>> + - interrupts : The interrupt line the device is connected to. >>>> + - interrupt-controller : Marks the device node as an interrupt controller. >>>> + - #interrupt-cells: The number of cells to describe an IRQ, this should be 2. >>>> + The first cell is the IRQ number. >>>> + The second cell is the flags, encoded as the trigger masks from >>>> + ../interrupt-controller/interrupts.txt >>> >>> Nit: We *normally* treat these as bullet-points and not place >>> full-stops on them: >>> >>> $ git grep "compatible" -- Documentation/devicetree/bindings/ | grep -v "\.$" | wc -l >>> 5227 >>> $ git grep "compatible.*\.$" -- Documentation/devicetree/bindings/ | wc -l >>> 486 >>> >> >> What about for multi-sentence descriptions, we need the middle full-stops, then to not >> have one on the end seems kinda odd looking. > > That's the way I usually do it -- doesn't look too bad. ;) > > [...] >