From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759507AbbJ3T2C (ORCPT ); Fri, 30 Oct 2015 15:28:02 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:35691 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751309AbbJ3T2A (ORCPT ); Fri, 30 Oct 2015 15:28:00 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: manoj@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-scsi@vger.kernel.org Reply-To: manoj@linux.vnet.ibm.com Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check References: <1446229378-2956-1-git-send-email-tim.gardner@canonical.com> To: tim.gardner@canonical.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jayamohan Kallickal , Minh Tran , John Soni Jose , "James E.J. Bottomley" From: Manoj Kumar Organization: IBM Message-ID: <5633C4D4.8080008@linux.vnet.ibm.com> Date: Fri, 30 Oct 2015 14:28:20 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446229378-2956-1-git-send-email-tim.gardner@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15103019-8236-0000-0000-0000132C057D Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tim: Reviewed-by: Manoj Kumar --- Manoj Kumar On 10/30/2015 1:22 PM, tim.gardner@canonical.com wrote: > From: Tim Gardner > > drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': > drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] > WARN_ON(!length > 0); > > gcc version 5.2.1 > > Cc: Jayamohan Kallickal > Cc: Minh Tran > Cc: John Soni Jose > Cc: "James E.J. Bottomley" > Signed-off-by: Tim Gardner > --- > drivers/scsi/be2iscsi/be_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index 7a6dbfb..5cdcd29 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address, > { > WARN_ON(!virtual_address); > WARN_ON(!physical_address); > - WARN_ON(!length > 0); > + WARN_ON(!length); > WARN_ON(!sgl); > > sgl->va = virtual_address; >