From: Chris J Arges <chris.j.arges@canonical.com>
To: Jessica Yu <jeyu@redhat.com>
Cc: live-patching@vger.kernel.org,
Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: livepatch: old_name@old_addr scheme in livepatch sysfs directory
Date: Sat, 31 Oct 2015 23:01:40 -0500 [thread overview]
Message-ID: <56358EA4.10900@canonical.com> (raw)
In-Reply-To: <20151101015258.GA8199@packer-debian-8-amd64.digitalocean.com>
On 10/31/2015 08:53 PM, Jessica Yu wrote:
> +++ Chris J Arges [30/10/15 22:44 -0500]:
>> The following directory structure will allow for cases when the same
>> function name exists in a single object.
>> /sys/kernel/livepatch/<patch>/<object>/<function@address>
>
> Hi Chris, thanks for the patch.
>
> I think the last time this issue was discussed, the conclusion was
> that concatenating the address to the function name constitutes as an
> information leak (as the sysfs entry is visible to non-root users).
>
> One option suggested by Josh in that thread would be to do something
> like "func.n", where n is just the nth occurrence of the symbol name.
> Another option might be to keep the func@addr format but not make these
> entries visible to non-root users.
>
> Jessica
>
Jessica,
Makes sense to me. Is there a reason why the sysfs entries are visible
to non-root users?
Otherwise, if there is a use-case for keeping the permissions the same,
then I'd be happy to to use the 'func.n' format for v2.
--chris
next prev parent reply other threads:[~2015-11-01 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 3:44 [PATCH] livepatch: old_name@old_addr scheme in livepatch sysfs directory Chris J Arges
2015-11-01 1:53 ` Jessica Yu
2015-11-01 4:01 ` Chris J Arges [this message]
2015-11-01 9:07 ` Jiri Kosina
2015-11-02 9:08 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56358EA4.10900@canonical.com \
--to=chris.j.arges@canonical.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox