From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
lee.jones@linaro.org, broonie@kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: sec-core: Rename MFD and regulator names differently
Date: Mon, 02 Nov 2015 13:19:28 +0900 [thread overview]
Message-ID: <5636E450.80002@samsung.com> (raw)
In-Reply-To: <1446437169-29550-1-git-send-email-alim.akhtar@samsung.com>
On 02.11.2015 13:06, Alim Akhtar wrote:
> Currently S2MPSXX multifunction device is named as *-pmic,
> and these MFDs also supports regulator as a one of its MFD cell which
> has the same name, because current name is confusing and we want to
> sort it out.
>
> We did discussed different approaches about how the MFD and it
> cells need to be named here [1].
> Based in the discussion this patch rename MFD regulator name as
> *-regulator instead of current *-pmic.
>
> This patch also changes the corresponding entries in the regulator driver
> to keep git-bisect happy.
>
> [1]-> https://lkml.org/lkml/2015/10/28/417
>
> Suggested-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> Changes since V1:
> * Squashed the two patches in one as sugeested by Lee
> * Based on the top of [1]
> [1]-> https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg47736.html
>
> drivers/mfd/sec-core.c | 8 ++++----
> drivers/regulator/s2mps11.c | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
Looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-11-02 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 4:06 [PATCH v2] mfd: sec-core: Rename MFD and regulator names differently Alim Akhtar
2015-11-02 4:19 ` Krzysztof Kozlowski [this message]
2015-11-04 13:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5636E450.80002@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox