Re: [PATCH] drm/sti: Remove select of CONFIG_FW_LOADER_USER_HELPER_FALLBACK

[Vincent ABRIOU <vincent.abriou@st.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1972 bytes --]

Hi Takashi,

I made a rework to load the firmware at a different time, when file 
system is available.
I am now able to remove FW_LOADER_USER_HELPER_FALLBACK.
I will submit a new patch for this.

Vincent

On 10/29/2015 03:53 PM, Takashi Iwai wrote:
> On Thu, 29 Oct 2015 15:37:51 +0100,
> Emil Velikov wrote:
>>
>> On 29 October 2015 at 14:21, Vincent ABRIOU <vincent.abriou@st.com> wrote:
>>> Hi Takashi,
>>>
>>> Removing FW_LOADER_USER_HELPER_FALLBACK leads to a failure in our HQVDP
>>> firmware execution.
>>> Indeed, our firmware is not built-in. It is a proprietary firmware
>>> uploaded into the file system that's why we need the
>>> USER_HELPER_FALLBACK to be able to load it once file system is available.
>>>
>> Hmm most other DRM drivers also require firmware. Whist some allow the
>> firmware to be picked in initrd it's not a strict requirement.
>> So I'm wondering how come there hasn't been (m)any reports,
>> considering that neither one sets USER_HELPER_FALLBACK.
>>
>> Perhaps they also need it, or something in the sti module is done
>> differently ? Just some food for thought.
>
> It's the option each user decides to set or not, depending on the
> deployed system.  Most of PCs don't need them, and actually enabling
> this option causes troubles for them.  On other embedded systems, this
> might be still needed.  So, it's the system setup issue, and not the
> thing a driver needs to care.
>
> Imagine that your driver has "select EXT3_FS" because your system
> requires it; without that option, it won't boot, OMG!
> Is it the right thing?  Obviously no.  The same logic is applied to
> this case, too.
>
>
> Takashi
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥