From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124AbbKBL5g (ORCPT ); Mon, 2 Nov 2015 06:57:36 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:43061 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753834AbbKBL53 (ORCPT ); Mon, 2 Nov 2015 06:57:29 -0500 X-AuditID: cbfee68f-f796f6d0000014a4-d6-56374fa79b74 Message-id: <56374FE3.9050805@samsung.com> Date: Mon, 02 Nov 2015 17:28:27 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Javier Martinez Canillas , linux-samsung-soc@vger.kernel.org Cc: k.kozlowski@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org Subject: Re: [PATCH 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node References: <1446458641-4447-1-git-send-email-alim.akhtar@samsung.com> <5637495D.1080701@osg.samsung.com> In-reply-to: <5637495D.1080701@osg.samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsWyRsSkRne5v3mYwaVp/Bbzj5xjtXjzdg2T xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY3Jg99i0qpPNY/OSeo8t/XfZPfq2rGL0+LxJLoA1 issmJTUnsyy1SN8ugSvjz5K0gunCFXfbpBoYj/F3MXJySAiYSHzs+MsOYYtJXLi3nq2LkYtD SGAFo8T/HVvZYYouHGlnhkgsZZR49nMdK4TzgFFiybo1jCBVvAJaErdf/gSzWQRUJW7ugxjL JqAtcXf6FqYuRg4OUYEIiccXhCDKBSV+TL7HAmKLCERJXJp9lQlkJrPAREaJKVvawRLCAv4S ax8fAZspJJAtMfHZaVYQm1NAX+LJ1gVg85kFbCUWvF/HAmHLS2xe8xbsUgmBS+wSO2YdYoI4 SEDi2+RDLCBHSAjISmw6wAzxmaTEwRU3WCYwis1CctMsJGNnIRm7gJF5FaNoakFyQXFSepGx XnFibnFpXrpecn7uJkZgxJ3+96x/B+PdA9aHGAU4GJV4eDPczcKEWBPLiitzDzGaAl0xkVlK NDkfGNd5JfGGxmZGFqYmpsZG5pZmSuK8C6V+BgsJpCeWpGanphakFsUXleakFh9iZOLgBMaX un506MYorlxXuwTTR6c1X5m6WTSzHrZ9W8/w29OV8+xSw5MLAtvftOwT3hLxNuJtW22J7E8e Rha3yQ/tixTy4hX4znSVM5kqrmEU9XFL/3HGc632Xf1p9e+Ft2nvZFncYX1oOnf8k8obpz7k 7WGT/HCI+V0YT4yoYFvIXCPjuhrfK71ZR5RYijMSDbWYi4oTAR0sbzezAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLIsWRmVeSWpSXmKPExsVy+t9jAd3l/uZhBs/PsFrMP3KO1eLN2zVM Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8mB3WPTqk42j81L6j229N9l9+jbsorR4/MmuQDW qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygK5QU yhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGX+WpBVMF6642ybVwHiMv4uR k0NCwETiwpF2ZghbTOLCvfVsXYxcHEICSxklnv1cxwrhPGCUWLJuDSNIFa+AlsTtlz/BbBYB VYmb+/6yg9hsAtoSd6dvYepi5OAQFYiQeHxBCKJcUOLH5HssILaIQJTEpdlXmUBmMgtMZJSY sqUdLCEs4C+x9vERsJlCAtkSE5+dZgWxOQX0JZ5sXQA2n1nAVmLB+3UsELa8xOY1b5knMArM QrJjFpKyWUjKFjAyr2KUSC1ILihOSs81ykst1ytOzC0uzUvXS87P3cQIjupn0jsYD+9yP8Qo wMGoxMN70NMsTIg1say4MvcQowQHs5II7w578zAh3pTEyqrUovz4otKc1OJDjKbAQJjILCWa nA9MOHkl8YbGJuamxqaWJhYmZpZK4rz6nkZhQgLpiSWp2ampBalFMH1MHJzASHAXUdO1nbfx oP7y2bx7H+gyKO/kPrOx6VdFuaaNe8myx/8/zFc11jWsvbYp4NK3nUXRJlHLfZ5O7n/+JnvJ 9x+bREo7vfkKfSfyBNUxlr7ZO/HW2SmatrphCsc7uj/aMqZpfDz8ZEnf1k1q5RunxZssWHj0 yJLah6fW6vEzXGBJ+aKyf5k3P78SS3FGoqEWc1FxIgAlOwxEAAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2015 05:00 PM, Javier Martinez Canillas wrote: > Hello Alim, > > This patch looks mostly good to me, I just have two comments below: > > On 11/02/2015 11:04 AM, Alim Akhtar wrote: >> This patch add pmic (s2mps15) node of espresso board, >> which includes addition of regulators and pmic-clk sub-nodes. >> >> Signed-off-by: Abhilash Kesavan >> Signed-off-by: Alim Akhtar >> --- >> This patch should go in after driver side changes [1] lands. >> [1]-> https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg47736.html >> >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 349 +++++++++++++++++++++++ >> 1 file changed, 349 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> index 838a3626dac1..8ce04a0ec928 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts >> @@ -53,6 +53,355 @@ >> status = "okay"; >> }; >> >> +&hsi2c_4 { >> + samsung,i2c-sda-delay = <100>; >> + samsung,i2c-max-bus-freq = <200000>; >> + status = "okay"; >> + >> + s2mps15_pmic@66 { >> + compatible = "samsung,s2mps15-pmic"; >> + reg = <0x66>; >> + interrupts = <2 0>; > > Maybe using IRQ_TYPE_NONE instead of 0? > Ok will check >> + interrupt-parent = <&gpa0>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmic_irq>; >> + wakeup-source; >> + >> + s2mps15_osc: clocks { >> + compatible = "samsung,s2mps13-clk"; >> + #clock-cells = <1>; >> + clock-output-names = "s2mps13_ap", "s2mps13_cp", >> + "s2mps13_bt"; >> + }; >> + >> + regulators { >> + ldo1_reg: LDO1 { >> + regulator-name = "vdd_ldo1"; >> + regulator-min-microvolt = <500000>; >> + regulator-max-microvolt = <900000>; >> + regulator-always-on; > > I see that all regulators are marked as regulator-always-on but that will > prevent the regulator subsystem to disable unused regulators. Can you please > double check which regulators should really be always on and which ones can > be disabled if are not used? > I kept it on always, as I am still in a process for validating all IPs on board. Will see if I can remove some of them, which I feel can be done. > After those two changes: > > Reviewed-by: Javier Martinez Canillas > Thanks! > Best regards, >