From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753702AbbKBMCL (ORCPT ); Mon, 2 Nov 2015 07:02:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbbKBMCI (ORCPT ); Mon, 2 Nov 2015 07:02:08 -0500 Subject: Re: [PATCH] KVM: x86: removing unused variable To: Saurabh Sengar , glen@nernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1446189971-8038-1-git-send-email-saurabh.truth@gmail.com> From: Paolo Bonzini Message-ID: <563750BA.7040104@redhat.com> Date: Mon, 2 Nov 2015 13:02:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446189971-8038-1-git-send-email-saurabh.truth@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/10/2015 08:26, Saurabh Sengar wrote: > removing unused variables, found by coccinelle > > Signed-off-by: Saurabh Sengar > --- > arch/x86/kvm/x86.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 9a9a198..ec15294 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -3424,41 +3424,35 @@ static int kvm_vm_ioctl_set_irqchip(struct kvm *kvm, struct kvm_irqchip *chip) > > static int kvm_vm_ioctl_get_pit(struct kvm *kvm, struct kvm_pit_state *ps) > { > - int r = 0; > - > mutex_lock(&kvm->arch.vpit->pit_state.lock); > memcpy(ps, &kvm->arch.vpit->pit_state, sizeof(struct kvm_pit_state)); > mutex_unlock(&kvm->arch.vpit->pit_state.lock); > - return r; > + return 0; > } > > static int kvm_vm_ioctl_set_pit(struct kvm *kvm, struct kvm_pit_state *ps) > { > - int r = 0; > - > mutex_lock(&kvm->arch.vpit->pit_state.lock); > memcpy(&kvm->arch.vpit->pit_state, ps, sizeof(struct kvm_pit_state)); > kvm_pit_load_count(kvm, 0, ps->channels[0].count, 0); > mutex_unlock(&kvm->arch.vpit->pit_state.lock); > - return r; > + return 0; > } > > static int kvm_vm_ioctl_get_pit2(struct kvm *kvm, struct kvm_pit_state2 *ps) > { > - int r = 0; > - > mutex_lock(&kvm->arch.vpit->pit_state.lock); > memcpy(ps->channels, &kvm->arch.vpit->pit_state.channels, > sizeof(ps->channels)); > ps->flags = kvm->arch.vpit->pit_state.flags; > mutex_unlock(&kvm->arch.vpit->pit_state.lock); > memset(&ps->reserved, 0, sizeof(ps->reserved)); > - return r; > + return 0; > } > > static int kvm_vm_ioctl_set_pit2(struct kvm *kvm, struct kvm_pit_state2 *ps) > { > - int r = 0, start = 0; > + int start = 0; > u32 prev_legacy, cur_legacy; > mutex_lock(&kvm->arch.vpit->pit_state.lock); > prev_legacy = kvm->arch.vpit->pit_state.flags & KVM_PIT_FLAGS_HPET_LEGACY; > @@ -3470,7 +3464,7 @@ static int kvm_vm_ioctl_set_pit2(struct kvm *kvm, struct kvm_pit_state2 *ps) > kvm->arch.vpit->pit_state.flags = ps->flags; > kvm_pit_load_count(kvm, 0, kvm->arch.vpit->pit_state.channels[0].count, start); > mutex_unlock(&kvm->arch.vpit->pit_state.lock); > - return r; > + return 0; > } > > static int kvm_vm_ioctl_reinject(struct kvm *kvm, > Applied, thanks. Paolo