public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Martyn Welch <martyn.welch@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
	swarren@wwwdotorg.org, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, abrestic@chromium.org
Subject: Re: [RFC 7/8] Start migrating XUSB away from MFD
Date: Mon, 02 Nov 2015 13:22:17 +0000	[thread overview]
Message-ID: <56376389.8030806@collabora.co.uk> (raw)
In-Reply-To: <20151102124732.GW4058@x1>



On 02/11/15 12:47, Lee Jones wrote:
> On Mon, 02 Nov 2015, Martyn Welch wrote:
>
>> From: Martyn Welch <martyn@welchs.me.uk>
>>
>> This is my initial attempt to get xusb working without being a MFD on the
>> latest upstream kernel. It's still a bit hacky in places, but does seem to
>> get the USB2 up and working (USB3 device is recognised as a USB3 device
>> rather than enumberating as a USB2 device).
> After my 20 second look at the 2 patches of this set you sent me, I've
> concluded that it looks barking mad.  In patch 2 you're adding the
> XUSB MFD driver, then in this patch you're telling us that you're
> moving away from MFD despite adding more code to the subsystem.

Hi Lee,

Sorry, seems git send-email added you of it's own volition.

I've sent these patches to the mailing list for comment/help not for 
submission. As mentioned in the cover email, the first 5 patches are 
from an existing series that has been rejected. The later 3 patches show 
my modifications. I have not yet moved these files from the MFD 
directory, but will before submission (the series will be reworked so 
that the driver never goes into the MFD area).

> Besides, I'm never applying a patch that self confesses to be "hacky
> in places" into Mainline, ever.

As I mentioned before, I'm posting these patches for comment (hence why 
I've marked them as "RFC" not "PATCH").

Martyn


  reply	other threads:[~2015-11-02 13:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-02 11:55 [RFC 0/8] Add support for NVIDIA Tegra XUSB Martyn Welch
2015-11-02 11:55 ` [RFC 1/8] mfd: Add driver " Martyn Welch
2015-11-02 11:55 ` [RFC 2/8] mailbox: Add NVIDIA Tegra XUSB mailbox driver Martyn Welch
2015-11-09  3:59   ` Jassi Brar
2015-11-02 11:55 ` [RFC 3/8] usb: xhci: Add NVIDIA Tegra xHCI host-controller driver Martyn Welch
2015-11-02 11:55 ` [RFC 4/8] pinctrl: tegra-xusb: Add USB PHY support Martyn Welch
2015-11-02 11:55 ` [RFC 5/8] pinctrl: tegra-xusb: Support PHY subnodes Martyn Welch
2015-11-02 11:55 ` [RFC 6/8] Adding binding for XUSB to tegra124 dtsi Martyn Welch
2015-11-02 11:55 ` [RFC 7/8] Start migrating XUSB away from MFD Martyn Welch
2015-11-02 12:47   ` Lee Jones
2015-11-02 13:22     ` Martyn Welch [this message]
2015-11-02 13:27       ` Lee Jones
2015-11-02 13:31         ` Martyn Welch
2015-11-02 11:55 ` [RFC 8/8] Registering mailbox from XUSB Child - Work in progress Martyn Welch
2015-11-02 17:20 ` [RFC 0/8] Add support for NVIDIA Tegra XUSB Stephen Warren
2015-11-02 17:27 ` Andrew Bresticker
2015-11-02 17:35   ` Martyn Welch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56376389.8030806@collabora.co.uk \
    --to=martyn.welch@collabora.co.uk \
    --cc=abrestic@chromium.org \
    --cc=jonathanh@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox