From: Ian Abbott <abbotti@mev.co.uk>
To: ranjithece24@gmail.com, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue
Date: Mon, 02 Nov 2015 14:36:00 +0000 [thread overview]
Message-ID: <563774D0.8050908@mev.co.uk> (raw)
In-Reply-To: <5637717d.0866420a.ecc6e.ffffe0f1@mx.google.com>
On 02/11/15 14:25, ranjithece24@gmail.com wrote:
> From: Ranjith <ranjithece24@gmail.com>
>
> BIT macro is used for defining BIT location instead of shifting
> operator - coding style issue
>
> Signed-off-by: Ranjith <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi_apci_1032.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index fd5ce21..168602b 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -84,7 +84,7 @@
> #define APCI1032_MODE2_REG 0x08
> #define APCI1032_STATUS_REG 0x0c
> #define APCI1032_CTRL_REG 0x10
> -#define APCI1032_CTRL_INT_OR (0 << 1)
> +#define APCI1032_CTRL_INT_OR BIT(0)
> #define APCI1032_CTRL_INT_AND BIT(1)
> #define APCI1032_CTRL_INT_ENA BIT(2)
No, that's wrong. (0 << 1) is 0, but BIT(0) is 1.
Hartley already fixed the coding style issue. It's in linux-next.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-11-02 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1446474307-6521-1-git-send-email-yes>
2015-11-02 14:25 ` [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue ranjithece24
2015-11-02 14:36 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563774D0.8050908@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox