* [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue
[not found] <1446474307-6521-1-git-send-email-yes>
@ 2015-11-02 14:25 ` ranjithece24
2015-11-02 14:36 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: ranjithece24 @ 2015-11-02 14:25 UTC (permalink / raw)
To: gregkh; +Cc: abbotti, hsweeten, devel, linux-kernel, ranjithece24
From: Ranjith <ranjithece24@gmail.com>
BIT macro is used for defining BIT location instead of shifting
operator - coding style issue
Signed-off-by: Ranjith <ranjithece24@gmail.com>
---
drivers/staging/comedi/drivers/addi_apci_1032.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
index fd5ce21..168602b 100644
--- a/drivers/staging/comedi/drivers/addi_apci_1032.c
+++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
@@ -84,7 +84,7 @@
#define APCI1032_MODE2_REG 0x08
#define APCI1032_STATUS_REG 0x0c
#define APCI1032_CTRL_REG 0x10
-#define APCI1032_CTRL_INT_OR (0 << 1)
+#define APCI1032_CTRL_INT_OR BIT(0)
#define APCI1032_CTRL_INT_AND BIT(1)
#define APCI1032_CTRL_INT_ENA BIT(2)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue
2015-11-02 14:25 ` [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue ranjithece24
@ 2015-11-02 14:36 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-11-02 14:36 UTC (permalink / raw)
To: ranjithece24, gregkh; +Cc: hsweeten, devel, linux-kernel
On 02/11/15 14:25, ranjithece24@gmail.com wrote:
> From: Ranjith <ranjithece24@gmail.com>
>
> BIT macro is used for defining BIT location instead of shifting
> operator - coding style issue
>
> Signed-off-by: Ranjith <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi_apci_1032.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_1032.c b/drivers/staging/comedi/drivers/addi_apci_1032.c
> index fd5ce21..168602b 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_1032.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_1032.c
> @@ -84,7 +84,7 @@
> #define APCI1032_MODE2_REG 0x08
> #define APCI1032_STATUS_REG 0x0c
> #define APCI1032_CTRL_REG 0x10
> -#define APCI1032_CTRL_INT_OR (0 << 1)
> +#define APCI1032_CTRL_INT_OR BIT(0)
> #define APCI1032_CTRL_INT_AND BIT(1)
> #define APCI1032_CTRL_INT_ENA BIT(2)
No, that's wrong. (0 << 1) is 0, but BIT(0) is 1.
Hartley already fixed the coding style issue. It's in linux-next.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-02 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1446474307-6521-1-git-send-email-yes>
2015-11-02 14:25 ` [PATCH 2/2] comedi: drivers: Fix - BIT macro used coding style issue ranjithece24
2015-11-02 14:36 ` Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox