public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dimitry Ishenko <dimitry@cos.flag.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH v12 1/5] Input: goodix - add sysfs interface to dump config
Date: Tue, 5 Sep 2017 17:16:29 -0400 (EDT)	[thread overview]
Message-ID: <563777.534131504646189349.JavaMail.root@webmail> (raw)
In-Reply-To: <27958492.533931504646096353.JavaMail.root@webmail>

> On Saturday, September 10, 2016 at 2:00:06 PM UTC-4, Irina Tirdea wrote: 
>
> Goodix devices have a configuration information register area that 
> specifies various parameters for the device. ...
>
> Export a sysfs interface that would allow reading the configuration 
> information. ...
>
> This sysfs interface will be exported only if the gpio pins are properly 
> initialized from ACPI/DT. ...

Irina, why the requirement for INT/RST gpio pins? The config info is 
available by simply reading from the config register (0x8047) and IIUIC
does not require presence of INT/RST pins. So, it can be exported even
without those pins.

Likewise, config writing support currently present in the kernel
(which I believe you are responsible for [thank you!]) also for some
reason mandates presence of INT/RST. However, it is simply done by
writing to the aforementioned config register (0x8047).

I have 2 similar devices (Pipo X8 and X9) with GT911 chips that have
different configs. Neither device has the RST pin defined.

I was able to successfully read the config from one device and
write it to the other. So, it seems the INT/RST requirement is not
necessary for config reading/writing support. Or did I miss something.

Thank you.

Dimitry

NB: I am not subscribed to the list. Please CC me directly with any replies.

       reply	other threads:[~2017-09-05 21:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <27958492.533931504646096353.JavaMail.root@webmail>
2017-09-05 21:16 ` Dimitry Ishenko [this message]
2016-09-10 17:57 [PATCH v12 0/5] Goodix touchscreen enhancements Irina Tirdea
2016-09-10 17:57 ` [PATCH v12 1/5] Input: goodix - add sysfs interface to dump config Irina Tirdea
2016-10-27 13:44   ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563777.534131504646189349.JavaMail.root@webmail \
    --to=dimitry@cos.flag.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox