From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbbKBQTZ (ORCPT ); Mon, 2 Nov 2015 11:19:25 -0500 Received: from lists.s-osg.org ([54.187.51.154]:54204 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbbKBQTX (ORCPT ); Mon, 2 Nov 2015 11:19:23 -0500 Subject: Re: [RFC PATCH] ACPI: Fix build errors due objects compiled unconditionally To: "Rafael J. Wysocki" References: <1444692990-10107-1-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org From: Javier Martinez Canillas Message-ID: <56378D05.3030602@osg.samsung.com> Date: Mon, 2 Nov 2015 17:19:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444692990-10107-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/13/2015 01:36 AM, Javier Martinez Canillas wrote: > If the CONFIG_ACPI Kconfig symbol is not enabled and a partial build is > attempted (make M=drivers/acpi), compile errors will happen due missing > types and identifiers. > > This is because objects are tried to be built unconditionally even when > CONFIG_ACPI is not enabled. This is usually not a problem since arches' > Kconfig sources drivers/acpi/Kconfig directly and also selects ACPI but > the Makefile should conditionally build the objects as well. > > Signed-off-by: Javier Martinez Canillas > Any comments about this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America