From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754289AbbKBQcc (ORCPT ); Mon, 2 Nov 2015 11:32:32 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37654 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754254AbbKBQcZ (ORCPT ); Mon, 2 Nov 2015 11:32:25 -0500 Subject: Re: [PATCH 03/22] clocksource/drivers/rockchip: Make the driver more compatible To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <1446469011-22710-3-git-send-email-daniel.lezcano@linaro.org> <5093304.EN6Bc2EjLr@wuerfel> Cc: tglx@linutronix.de, Heiko Stuebner , linux-kernel@vger.kernel.org, "open list:ARM/Rockchip SoC..." , john.stultz@linaro.org, Caesar Wang From: Daniel Lezcano Message-ID: <56379016.1080601@linaro.org> Date: Mon, 2 Nov 2015 17:32:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5093304.EN6Bc2EjLr@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2015 04:33 PM, Arnd Bergmann wrote: > On Monday 02 November 2015 13:56:31 Daniel Lezcano wrote: >> static inline void rk_timer_disable(struct clock_event_device *ce) >> { >> writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG); >> - dsb(); >> + dsb(sy); >> } >> >> static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags) >> { >> writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags, >> rk_base(ce) + TIMER_CONTROL_REG); >> - dsb(); >> + dsb(sy); >> } >> >> > > This will fail the compile test, because dsb() is not available on non-ARM > architectures. Would it be enough to just use the normal writel() accessor > here? That's a good question and I believe we can remove it but I have to setup a rockchip board before doing the changes in order to test. I the meantime added the COMPILE_TEST option but restricted it to ARM and ARM64. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog