Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

Sinan Kaya
2015-11-03T04:18:47Z

On 11/2/2015 11:15 PM, Vinod Koul wrote:
> On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote:
>> This patch adds supporting utility functions
>> for selftest. The intention is to share the self
>> test code between different drivers.
>>
>> Supported test cases include:
>> 1. dma_map_single
>> 2. streaming DMA
>> 3. coherent DMA
>> 4. scatter-gather DMA
>
> This seems quite similar to dmatest, any reason why you cannot use/enhance
> that?
>
Dmatest is a standalone kernel module intended for stress testing DMA
engines from userspace with N number of threads and M size combinations etc.

This one; on the other hand, is selftest to verify hardware is working
as expected during power up.

Almost all DMA engine drivers come with some sort of selftest code
called from probe. I followed the same design pattern.

I think the goal is to remove the duplicate self test code in all
drivers over time.

--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project