Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

Vinod Koul
2015-11-03T16:05:32Z

On Tue, Nov 03, 2015 at 10:22:25AM +0200, Andy Shevchenko wrote:
> On Tue, Nov 3, 2015 at 9:44 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> > On Mon, Nov 2, 2015 at 10:30 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> >> On Mon, Nov 02, 2015 at 11:18:37PM -0500, Sinan Kaya wrote:
> >>> On 11/2/2015 11:15 PM, Vinod Koul wrote:
> >>> >On Mon, Nov 02, 2015 at 01:07:38AM -0500, Sinan Kaya wrote:
>
>
> >>> This one; on the other hand, is selftest to verify hardware is
> >>> working as expected during power up.
>
> I prefer to have such nice case by run time parameter (let's say
> common to all DMA Engine drivers)
>
> >> We can have common code which is used for dmatest as well as selftest. I do
> >> not want to see same code duplicated..
>
> First thought was to merge this to dmatest, however, some DMA
> controllers doesn't have a memcpy capability.

The tests should be based on capablity of memcpy

> How would we test them?

That part is tricky, you need to do so thru clients, spi/audio/serial etc

--
~Vinod