Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

Vinod Koul
2015-11-03T16:04:55Z

On Mon, Nov 02, 2015 at 11:44:23PM -0800, Dan Williams wrote:
> Originally ioatdma and iop-adma had local self tests before Haavard
> created dmatest. I agree having the drivers also do a test each boot
> is redundant, but then again dmatest is not automatic and I saw the
> local self test catch an interrupt setup regression.

Well the question here is not about why selftest but rather code duplication
and using same routines for both selftest as well as dmatest
>
> Maybe you could arrange for drivers to do a quick autorun through
> dmatest on load if dmatest is enabled, but otherwise load without
> testing?

That would be a good thing to do, but then most distro just enable all
config options, so this should be protected for "test" builds

> Just my 2 cents from a dmaengine spectator.

Thats an understatement :)

> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
~Vinod