From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbKCAbJ (ORCPT ); Mon, 2 Nov 2015 19:31:09 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51647 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbbKCAbC (ORCPT ); Mon, 2 Nov 2015 19:31:02 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-c8-563800431e4a Subject: Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option To: Daniel Lezcano , tglx@linutronix.de References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org> Cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Russell King , Kukjin Kim , "moderated list:ARM SUB-ARCHITECT..." , "moderated list:ARM/SAMSUNG EXYNO..." From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56380040.3080600@samsung.com> Date: Tue, 03 Nov 2015 09:30:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42I5/e/4FV1nBoswg12nLCz+TjrGbjHvs6zF md+6Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8ni9mVei82bpjI7cHm0NPewefz+NYnRY9Oq TjaPO9f2sHm8O3eO3WPzknqPvi2rGD0+b5IL4IjisklJzcksSy3St0vgyljb1cNYcJ+3YuHG BWwNjF+5uhg5OSQETCT+PH/FCmGLSVy4t56ti5GLQ0hgKaPEwzd3mSCcL4wSa94cYQepEhZI kdi7eweYLSLgJLHt5j5WiKIuRom5B3ewgDjMAmuYJG4tmABWxSZgLLF5+RI2iB1yEr3dk4CK ODh4BbQk9p4NBgmzCKhKHPv7G6xEVCBCYuKEBrCTeAUEJX5MvscCYnMKeEscPLCPGaSVWUBP 4v5FLZAws4C8xOY1b5knMArOQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1kvNz NzFC4uXLDsbFx6wOMQpwMCrx8C5YYh4mxJpYVlyZe4hRgoNZSYTXaT9QiDclsbIqtSg/vqg0 J7X4EKM0B4uSOO/cXe9DhATSE0tSs1NTC1KLYLJMHJxSDYyCOzYcftWhd9g3ve76DZv36/OK bsZv/PI7JiT/z6eHr53n/0m86vpUdC87x6y3gbdDbZ6d1FdnVpSyvdF3a139QRWHjzZZx3k/ TVK5L7to7ZwTmly7vOx+6/uqSy+uPKAism7SuR+/kg91aN2rmZH1rXPmPMV+3caD27hsnsgs crv+d/q/xiYRJZbijERDLeai4kQAIPQb6ZMCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.11.2015 21:56, Daniel Lezcano wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options. Selecting user-visible symbols is rather discouraged so why not something like this: - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) Best regards, Krzysztof > > Add the COMPILE_TEST option for the compilation test coverage. Due to the > non portable 'delay' code, this driver is only compilable on ARM. > > Signed-off-by: Daniel Lezcano > --- > arch/arm/mach-exynos/Kconfig | 1 + > drivers/clocksource/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..ff10539 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select CLKSRC_EXYNOS_MCT > help > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 916c36d..d829cbe 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC > This option enables support for the Meta per-thread timers. > > config CLKSRC_EXYNOS_MCT > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" if COMPILE_TEST > + depends on ARM > help > Support for Multi Core Timer controller on Exynos SoCs. > >