From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754084AbbKCAzJ (ORCPT ); Mon, 2 Nov 2015 19:55:09 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52212 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbbKCAzG (ORCPT ); Mon, 2 Nov 2015 19:55:06 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79ae6d00000149a-bc-563805ce2fcb Content-transfer-encoding: 8BIT Message-id: <563805CE.8000904@samsung.com> Date: Tue, 03 Nov 2015 09:54:38 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Daniel Lezcano , tglx@linutronix.de Cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Russell King , Kukjin Kim , Krzysztof Kozlowski , "moderated list:ARM SUB-ARCHITECT..." , "moderated list:ARM/SAMSUNG EXYNO..." Subject: Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org> In-reply-to: <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRmVeSWpSXmKPExsWyRsSkUPc8q0WYwYsJjBZ/Jx1jt5j3Wdbi zG9di9cvDC36H79mttj0+BqrxeVdc9gsZpzfx2Rx+zKvxeZNU5kduDxamnvYPH7/msTosWlV J5vHnWt72DzenTvH7rF5Sb1H35ZVjB6fN8kFcERx2aSk5mSWpRbp2yVwZXz9fputYD1vRffX J2wNjE+4uhg5OSQETCTu/n/NDGGLSVy4t56ti5GLQ0hgBaPE1m1fWGCK9v64ywqRWMoosbzz ADtIgldAUOLH5HtARRwczALyEkcuZYOEmQXUJSbNW8QMUf+AUaL7/RFWiHotiV0n14LZLAKq Ep2nPoBtZgOK739xgw1kjqhAhET3iUqQsIiAk8S2m/vA9jIL3GWS+LbkL1i9sECKxN7dO9gh FnQxSsw9uAPsUk4Bb4mDB/aBbZYQ+MsucWX+S3aIbQIS3yYfArtUQkBWYtMBqJclJQ6uuMEy gVFsFpJ/ZiH8MwvJPwsYmVcxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525iBEbq6X/Pencw3j5g fYhRgINRiYf3xzLzMCHWxLLiytxDjKZAR0xklhJNzgemg7ySeENjMyMLUxNTYyNzSzMlcV5F qZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhgP3szyeP903wxr23hdCZ1nwvvc/5wWP3/N 5Ogbp4fMYZe2a6uuOyDfP6355Ls+vcS6cJey5Sv1dpyewRT7ZAYPS86Ju/dNmkNPvrp8/EjP n58BIZtuno1YJTlt/rSl8tt3W1k638mKUz5wStipMTvKILVjVuLDKdW8EdwzH08Q4cuVtF9X 0rRPiaU4I9FQi7moOBEAgCc4588CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkleLIzCtJLcpLzFFi42I5/e+xgO45Voswg6t7LCz+TjrGbjHvs6zF md+6Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8ni9mVei82bpjI7cHm0NPewefz+NYnRY9Oq TjaPO9f2sHm8O3eO3WPzknqPvi2rGD0+b5IL4IhqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneO NzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpQSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5v SBBcj5EBGkhYw5jx9ftttoL1vBXdX5+wNTA+4epi5OSQEDCR2PvjLiuELSZx4d56ti5GLg4h gaWMEss7D7CDJHgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i0rxFzBD1Dxglut8fYYWo15LY dXItmM0ioCrReeoDM4jNBhTf/+IGG8gcUYEIie4TlSBhEQEniW0397GCzGEWuMsk8W3JX7B6 YYEUib27d7BDLOhilJh7cAcLSIJTwFvi4IF9zBMYBWYhuW8Wwn2zkNy3gJF5FaNEakFyQXFS eq5RXmq5XnFibnFpXrpecn7uJkZwMngmvYPx8C73Q4wCHIxKPLwLlpiHCbEmlhVX5h5ilOBg VhLhddoPFOJNSaysSi3Kjy8qzUktPsRoCvTgRGYp0eR8YKLKK4k3NDYxM7I0Mje0MDI2VxLn 1fc0ChMSSE8sSc1OTS1ILYLpY+LglGpgVD4Q/+Exf5HU9g3rbmZfml4W53TZc9bSGzv4t1Wc cPx1UkMo5kb5dbYne2fGu3/MY2pXTLEvNrsn9DKP1d7QgTM4feVLgQfV1wv2TNNSaJzoU+yv PDVjOdedH8I8aw4W/jfUmbZW8et3E+Zai3eyKSlXuAv1q/7W/svIUVPfnGJ057JcmrW2Ektx RqKhFnNRcSIAlEzKchwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2015년 11월 02일 21:56, Daniel Lezcano wrote: > Let the platform's Kconfig to select the clock instead of having a reverse > dependency from the driver to the platform options. > > Add the COMPILE_TEST option for the compilation test coverage. Due to the > non portable 'delay' code, this driver is only compilable on ARM. > > Signed-off-by: Daniel Lezcano > --- > arch/arm/mach-exynos/Kconfig | 1 + > drivers/clocksource/Kconfig | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 3a10f1a..ff10539 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS > select SRAM > select THERMAL > select MFD_SYSCON > + select CLKSRC_EXYNOS_MCT > help > Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig > index 916c36d..d829cbe 100644 > --- a/drivers/clocksource/Kconfig > +++ b/drivers/clocksource/Kconfig > @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC > This option enables support for the Meta per-thread timers. > > config CLKSRC_EXYNOS_MCT > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" if COMPILE_TEST > + depends on ARM > help > Support for Multi Core Timer controller on Exynos SoCs. > > Looks good to me. As you commented, delay_timer is only used on ARM 32bit. I'm glad to use the 'depends on ARM' instead of reverse dependency. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi