From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754018AbbKCLVT (ORCPT ); Tue, 3 Nov 2015 06:21:19 -0500 Received: from mail-qg0-f51.google.com ([209.85.192.51]:34656 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbbKCLVQ (ORCPT ); Tue, 3 Nov 2015 06:21:16 -0500 Subject: Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400) To: Cong Wang , Sasha Levin References: <56377FC9.90601@oracle.com> Cc: "netdev@vger.kernel.org" , "David S. Miller" , LKML , syzkaller@googlegroups.com, Dmitry Vyukov From: Marcelo Ricardo Leitner Message-ID: <563898A5.9050200@gmail.com> Date: Tue, 3 Nov 2015 09:21:09 -0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em 02-11-2015 22:38, Cong Wang escreveu: > On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang wrote: >> >> Good catch! >> >> This is probably introduced by: >> >> commit baf606d9c9b12517e47e0d1370e8aa9f7323f210 >> Author: Marcelo Ricardo Leitner >> Date: Wed Mar 18 14:50:42 2015 -0300 >> >> ipv4,ipv6: grab rtnl before locking the socket Yes, that commit introduced this inverse order situation by not fixing the get path of it. >> I am thinking what is the right way to fix it... > > Please try the attached patch. > > Thanks! Patch LGTM, same design and covered all rtnl_lock()s I could find on get path now. Thanks! Marcelo