Re: [PATCH v2 5/6] regulator: tps65086: Add regulator driver for the TPS65086 PMIC

Mark Brown
2015-11-02T08:53:56Z

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Fri, Oct 30, 2015 at 05:41:43PM -0500, Andrew F. Davis wrote:

> +struct tps65086_regulator {
> + struct regulator_desc desc;
> + unsigned int decay_reg;
> + unsigned int decay_mask;

The decay_reg and decay_mask fields appear to be entirely write only,
why are they present?

> + ret = of_regulator_match(&pdev->dev, pdev->dev.of_node,
> + tps65086_matches,
> + ARRAY_SIZE(tps65086_matches));
> + if (ret < 0) {
> + dev_err(tps->dev, "Error parsing regulator init data\n");
> + return ret;
> + }

Please match regulators using the fields in the regulator_desc rather
than open coding.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]