From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: kbuild test robot <lkp@intel.com>, <kbuild-all@01.org>,
<tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<bp@suse.de>, <x86@kernel.org>, <sudeep.holla@arm.com>,
<akpm@linux-foundation.org>, <geliangtang@163.com>,
<tj@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h systems
Date: Tue, 3 Nov 2015 13:58:51 -0600 [thread overview]
Message-ID: <563911FB.9070405@amd.com> (raw)
In-Reply-To: <20151103195246.GB3644@pd.tnic>
On 11/3/2015 1:52 PM, Borislav Petkov wrote:
> On Tue, Nov 03, 2015 at 01:41:53PM -0600, Aravind Gopalakrishnan wrote:
>> cpu_llc_id references should be wrapped under #ifdef CONFIG_SMP.
>>
>> Did that and kernel build worked with the attached config.
>>
>> Will send a V2 with the fix.
> Why aren't you doing all that figuring out what the llc_id is in
> amd_detect_cmp() which is already CONFIG_SMP ifdeffed?
>
> Which is where that code belongs anyway...
>
Since we needed to modify last level cache IDs, I thought
init_amd_cacheinfo() might be a logical place to put it.
But you are right, makes sense to move it to amd_detect_cmp().
I'll do that in V2.
Thanks,
-Aravind.
prev parent reply other threads:[~2015-11-03 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 19:15 [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h systems Aravind Gopalakrishnan
2015-11-03 19:27 ` kbuild test robot
2015-11-03 19:41 ` Aravind Gopalakrishnan
2015-11-03 19:52 ` Borislav Petkov
2015-11-03 19:58 ` Aravind Gopalakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563911FB.9070405@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=geliangtang@163.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox