From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756279AbbKDSUS (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Nov 2015 13:20:18 -0500
Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:34359 "EHLO
	eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1756209AbbKDSUR convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Nov 2015 13:20:17 -0500
Subject: Re: [PATCHv2 2/4] arm-cci: Get the status of a counter
To: Mark Rutland <mark.rutland@arm.com>
References: <1445346326-30820-1-git-send-email-suzuki.poulose@arm.com>
 <1445346326-30820-3-git-send-email-suzuki.poulose@arm.com>
 <20151104180651.GG23860@leverpostej>
Cc: linux-arm-kernel@lists.infradead.org, punit.agrawal@arm.com,
        arm@kernel.org, linux-kernel@vger.kernel.org
From: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Message-ID: <563A4C5D.4010703@arm.com>
Date: Wed, 4 Nov 2015 18:20:13 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151104180651.GG23860@leverpostej>
X-OriginalArrivalTime: 04 Nov 2015 18:20:13.0627 (UTC) FILETIME=[72BAD8B0:01D1172D]
X-MC-Unique: QrG20mqVQ_-qzf5bJfsG6g-1
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/11/15 18:06, Mark Rutland wrote:
> On Tue, Oct 20, 2015 at 02:05:24PM +0100, Suzuki K. Poulose wrote:
>> Add helper routines to get the counter status and the event
>> programmed on it.
>>

>> +static u32 pmu_get_counter_ctrl(struct cci_pmu *cci_pmu, int idx)
>> +{
>> +	return pmu_read_register(cci_pmu, idx, CCI_PMU_CNTR_CTRL) & 0x1;
>> +}
>
> Given the function is called pmu_get_counter_ctrl, why the '& 1'?

Thats because the Count Control has only 1 bit defined. The rest is RES0.

>
> Either this should return the raw value, or the function should be
> renamed to something like pmu_counter_is_enabled, and made bool.

Makes sense. I will change it to pmu_counter_is_enabled().

Thanks
Suzuki