From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161400AbbKENkp (ORCPT ); Thu, 5 Nov 2015 08:40:45 -0500 Received: from mout.web.de ([212.227.17.11]:56830 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161356AbbKENkm (ORCPT ); Thu, 5 Nov 2015 08:40:42 -0500 Subject: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put" To: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <563B5C52.2060507@users.sourceforge.net> Date: Thu, 5 Nov 2015 14:40:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:E3E5B5IQvGPa5R4gvi4GsoqAs3ReAv/bHHjg6M6Rq0xsYNeK3Kr 7sBknoE+D+mt6wHySdI8d20kpleaEwBfsKQwSyRQrtMoWx4Ui0MilGmwwcs3pLkAf27ka6g +2c3IWZ1hPKQztzTh9XtDUxLbbd280IHELDQ/ADsToFc2mrgtO8LAQDBW6Sjat0c324eKvG A3ibJu8Jc3du/KYtsja8g== X-UI-Out-Filterresults: notjunk:1;V01:K0:PpZf7NGPvFc=:yMM2SV3d/orxzA5DwGdE9U 8Gbd02CN+kRFHfe0FVMpODSStr/9C4qRlcd/3/zz5WQ/CM7ocuTQVI0od41eD/GfKgfVyUC7/ 0zxAbOEEhBn/30CzoI4YIGdfEVV046ivTh9MJqBAAEgONLCpqW8HF/77K2wZ9nTJ6ybsUBIbC KQ3mecoBmxg4Mn3TzyP0NmWM9hst1CDkwOiZCQXNG5wS5ULn2ZEm9weoo3VvmopjPb5boTpFZ NF2UTWCtmcRaYMuvq6WAUclovL1H/duRvvv+fVsYzNz2cvTtPfu7uuAG2p2UWNzLy45NL8idP lOVE86YBJO4yhyq27uzNmNJrZUUfRSQQul7InZqLFTyhCxrcXLHpTc7LCe0Cu/8QqJD7mRaz3 liwvGPh0G8tsB4dI05QVM4QstptLj5oBV9Ev4ZZnYwXxLD9KidRPy7rqE/7hCNlfIVK+O6yGU /qKVhD8sIptm7k0ykc0mnrQjFGo16Tn0wKu+Xvr3mvdQ5C88HXrdjrk2hflRd6GVNmrPSDuWF bYxNH+DDybi6LzHNKnwpQvw+u7Uj95UHolfcqfJAZvb0hVw5CpE74xwFVHaAtCcN+zbHCRDha Pc+Ooeeknm/U7dFihfYc3Il6yf/LgYF0+R3+Bp8H3cWVUzxngzvpT8S6Xut7WRlen5CR0T8zZ iBpf2tH6jeHpfy6XN3RyXVb3TVruQ1KyKok8gEnh4DkBnQZ1qv9ZVHNWiyjgHxGMSjdXt46j4 ETDRyeTkfDAT2UBGVQripr5gx4Ozq2zUAN4q3ez3HYuOcx6WlRsA7BwXK72Y2kginl/duDY7O hV3wdwa Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Nov 2015 14:34:43 +0100 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/most/mostcore/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/most/mostcore/core.c b/drivers/staging/most/mostcore/core.c index 19852ca..ed1ed25 100644 --- a/drivers/staging/most/mostcore/core.c +++ b/drivers/staging/most/mostcore/core.c @@ -1587,8 +1587,7 @@ out: return 0; error: - if (iface->mod) - module_put(iface->mod); + module_put(iface->mod); modref--; mutex_unlock(&c->start_mutex); return ret; -- 2.6.2