* [PATCH V2] Intel device IDs Audio [not found] <[PATCH V2] Intel device IDs Audio> @ 2015-11-04 23:56 ` Alexandra Yates 2015-11-05 10:29 ` Takashi Iwai 0 siblings, 1 reply; 4+ messages in thread From: Alexandra Yates @ 2015-11-04 23:56 UTC (permalink / raw) To: perex, tiwai, alsa-devel, linux-kernel; +Cc: Alexandra Yates Adding Intel codename Lewisburg platform device IDs for audio. Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com> --- sound/pci/hda/hda_intel.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index c38c68f..e8d1151 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = { /* ICH10 */ { PCI_DEVICE(0x8086, 0x3a6e), .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH }, + /* Lewisburg */ + { PCI_DEVICE(0x8086, 0xa1f0), + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, + { PCI_DEVICE(0x8086, 0xa270), + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, /* Generic Intel */ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID), .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8, -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] Intel device IDs Audio 2015-11-04 23:56 ` [PATCH V2] Intel device IDs Audio Alexandra Yates @ 2015-11-05 10:29 ` Takashi Iwai 2015-11-05 19:51 ` Alexandra Yates 0 siblings, 1 reply; 4+ messages in thread From: Takashi Iwai @ 2015-11-05 10:29 UTC (permalink / raw) To: Alexandra Yates; +Cc: alsa-devel, perex, linux-kernel On Thu, 05 Nov 2015 00:56:09 +0100, Alexandra Yates wrote: > > Adding Intel codename Lewisburg platform device IDs for audio. > > Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com> Thanks. Though, I still believe the position after Wellsburg is best (which is the similar chip that has the same driver type and driver caps bits), so I rearranged it. Also the subject was aligned. And last but not least, Cc to stable was added. Takashi > --- > sound/pci/hda/hda_intel.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index c38c68f..e8d1151 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = { > /* ICH10 */ > { PCI_DEVICE(0x8086, 0x3a6e), > .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH }, > + /* Lewisburg */ > + { PCI_DEVICE(0x8086, 0xa1f0), > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, > + { PCI_DEVICE(0x8086, 0xa270), > + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, > /* Generic Intel */ > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID), > .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8, > -- > 1.9.1 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] Intel device IDs Audio 2015-11-05 10:29 ` Takashi Iwai @ 2015-11-05 19:51 ` Alexandra Yates 2015-11-05 21:17 ` Takashi Iwai 0 siblings, 1 reply; 4+ messages in thread From: Alexandra Yates @ 2015-11-05 19:51 UTC (permalink / raw) To: Takashi Iwai; +Cc: alsa-devel, perex, linux-kernel Takashi, On 11/05/2015 02:29 AM, Takashi Iwai wrote: > On Thu, 05 Nov 2015 00:56:09 +0100, > Alexandra Yates wrote: >> >> Adding Intel codename Lewisburg platform device IDs for audio. >> >> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com> > > Thanks. Though, I still believe the position after Wellsburg is best > (which is the similar chip that has the same driver type and driver > caps bits), so I rearranged it. Also the subject was aligned. > And last but not least, Cc to stable was added. > Thank you for your review and making the additional changes. I'll keep your methodology for future reference. Is this mean that the patch was accepted upstream? > > Takashi > >> --- >> sound/pci/hda/hda_intel.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c >> index c38c68f..e8d1151 100644 >> --- a/sound/pci/hda/hda_intel.c >> +++ b/sound/pci/hda/hda_intel.c >> @@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = { >> /* ICH10 */ >> { PCI_DEVICE(0x8086, 0x3a6e), >> .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH }, >> + /* Lewisburg */ >> + { PCI_DEVICE(0x8086, 0xa1f0), >> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, >> + { PCI_DEVICE(0x8086, 0xa270), >> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, >> /* Generic Intel */ >> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID), >> .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8, >> -- >> 1.9.1 >> >> -- Thank you, <Alexandra> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] Intel device IDs Audio 2015-11-05 19:51 ` Alexandra Yates @ 2015-11-05 21:17 ` Takashi Iwai 0 siblings, 0 replies; 4+ messages in thread From: Takashi Iwai @ 2015-11-05 21:17 UTC (permalink / raw) To: Alexandra Yates; +Cc: alsa-devel, perex, linux-kernel On Thu, 05 Nov 2015 20:51:52 +0100, Alexandra Yates wrote: > > Takashi, > > On 11/05/2015 02:29 AM, Takashi Iwai wrote: > > On Thu, 05 Nov 2015 00:56:09 +0100, > > Alexandra Yates wrote: > >> > >> Adding Intel codename Lewisburg platform device IDs for audio. > >> > >> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com> > > > > Thanks. Though, I still believe the position after Wellsburg is best > > (which is the similar chip that has the same driver type and driver > > caps bits), so I rearranged it. Also the subject was aligned. > > And last but not least, Cc to stable was added. > > > > Thank you for your review and making the additional changes. I'll keep > your methodology for future reference. > > Is this mean that the patch was accepted upstream? Yes :) Takashi > > > > Takashi > > > >> --- > >> sound/pci/hda/hda_intel.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > >> index c38c68f..e8d1151 100644 > >> --- a/sound/pci/hda/hda_intel.c > >> +++ b/sound/pci/hda/hda_intel.c > >> @@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = { > >> /* ICH10 */ > >> { PCI_DEVICE(0x8086, 0x3a6e), > >> .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH }, > >> + /* Lewisburg */ > >> + { PCI_DEVICE(0x8086, 0xa1f0), > >> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, > >> + { PCI_DEVICE(0x8086, 0xa270), > >> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH }, > >> /* Generic Intel */ > >> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID), > >> .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8, > >> -- > >> 1.9.1 > >> > >> > > -- > Thank you, > <Alexandra> > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-05 21:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <[PATCH V2] Intel device IDs Audio>
2015-11-04 23:56 ` [PATCH V2] Intel device IDs Audio Alexandra Yates
2015-11-05 10:29 ` Takashi Iwai
2015-11-05 19:51 ` Alexandra Yates
2015-11-05 21:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox