Re: [PATCH v2 02/11] fsl-mc: msi: Added FSL-MC-specific member to the msi_desc's union

[Jiang Liu <jiang.liu@linux.intel.com>]

On 2015/10/31 3:43, J. German Rivera wrote:
> FSL-MC is a bus type different from PCI and platform, so it needs
> its own member in the msi_desc's union.
> 
> Signed-off-by: J. German Rivera <German.Rivera@freescale.com>
> ---
> Changes in v2:
> - Addressed comment from Jiang Liu
>   * Added a dedicated structure for FSL-MC in struct msi_desc
> 
>  include/linux/msi.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index f71a25e..152e51a 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -33,6 +33,14 @@ struct platform_msi_desc {
>  };
> 
>  /**
> + * fsl_mc_msi_desc - FSL-MC device specific msi descriptor data
> + * @msi_index:		The index of the MSI descriptor
> + */
> +struct fsl_mc_msi_desc {
> +	u16				msi_index;
> +};
> +
> +/**
>   * struct msi_desc - Descriptor structure for MSI based interrupts
>   * @list:	List head for management
>   * @irq:	The base interrupt number
> @@ -87,6 +95,7 @@ struct msi_desc {
>  		 * tree wide cleanup.
>  		 */
>  		struct platform_msi_desc platform;
> +		struct fsl_mc_msi_desc fsl_mc;
>  	};
>  };

Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>

> 
> --
> 2.3.3
>