public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Andy Gross <agross@codeaurora.org>, linux-usb@vger.kernel.org
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Peter Chen <Peter.Chen@freescale.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: host: ehci-msm: Use posted data writes on AHB
Date: Fri, 6 Nov 2015 12:13:00 +0200	[thread overview]
Message-ID: <563C7D2C.9080909@linaro.org> (raw)
In-Reply-To: <1446789847-640-3-git-send-email-agross@codeaurora.org>

On 11/06/2015 08:04 AM, Andy Gross wrote:
> This patch sets the AHBMODE to allow for posted data writes.  This
> results in higher performance.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>

With these patches I see significant improvement in throughput
on my db410c board.

Tested-by: Georgi Djakov <georgi.djakov@linaro.org>

> ---
>  drivers/usb/host/ehci-msm.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c
> index c4f84c8..c23e285 100644
> --- a/drivers/usb/host/ehci-msm.c
> +++ b/drivers/usb/host/ehci-msm.c
> @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd)
>  
>  	/* bursts of unspecified length. */
>  	writel(0, USB_AHBBURST);
> -	/* Use the AHB transactor */
> -	writel(0, USB_AHBMODE);
> +	/* Use the AHB transactor, allow posted data writes */
> +	writel(0x8, USB_AHBMODE);
>  	/* Disable streaming mode and select host mode */
>  	writel(0x13, USB_USBMODE);
>  
> 


  reply	other threads:[~2015-11-06 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  6:04 [PATCH 0/2] Configure AHB to post data transfers Andy Gross
2015-11-06  6:04 ` [PATCH 1/2] usb: chipidea: msm: Use posted data writes on AHB Andy Gross
2015-11-06  8:24   ` Peter Chen
2015-11-06  6:04 ` [PATCH 2/2] usb: host: ehci-msm: " Andy Gross
2015-11-06 10:13   ` Georgi Djakov [this message]
2015-11-06 15:41     ` Alan Stern
2015-12-10 17:51   ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C7D2C.9080909@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=Peter.Chen@freescale.com \
    --cc=agross@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox