public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Zain <zain.wang@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: zhengsq@rock-chips.com, hl@rock-chips.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	mturquette@baylibre.com, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	mark.rutland@arm.com, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, eddie.cai@rock-chips.com
Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288
Date: Fri, 6 Nov 2015 18:27:33 +0800	[thread overview]
Message-ID: <563C8095.30905@rock-chips.com> (raw)
In-Reply-To: <4509145.eZ7GP0e6gb@phil>



On 2015年11月06日 18:12, Heiko Stuebner wrote:
> Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>>  arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>>  		};
>>  	};
>>  
>> +	crypto: cypto-controller@ff8a0000 {
>> +		compatible = "rockchip,rk3288-crypto";
>> +		reg = <0xff8a0000 0x4000>;
>> +		interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>> +		clocks = <&cru ACLK_CRYPTO>,
>> +			 <&cru HCLK_CRYPTO>,
>> +			 <&cru SCLK_CRYPTO>,
>> +			 <&cru ACLK_DMAC1>;
>> +		clock-names = "aclk",
>> +			      "hclk",
>> +			      "sclk",
>> +			      "apb_pclk";
>> +		status = "okay";
>> +	};
>> +
> please move that whole node to the right location. Entries are sorted by 
> register address (the ff8a0000 should then of course be below  i2s@ff890000 
> and above vop@ff930000)
ok! done!
>
>
>>  	reserved-memory {
>>  		#address-cells = <1>;
>>  		#size-cells = <1>;
>>
>
>
>



  reply	other threads:[~2015-11-06 10:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  1:17 [PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288 Zain Wang
2015-11-06  1:17 ` [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 " Zain Wang
2015-11-06  1:54   ` Caesar Wang
2015-11-06  9:51     ` Zain
2015-11-07 23:19   ` Heiko Stuebner
2015-11-09  3:46     ` Zain
2015-11-06  1:17 ` [PATCH v2 2/4] clk: rockchip: set an id for crypto clk Zain Wang
2015-11-06  1:17 ` [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Zain Wang
2015-11-06  2:00   ` Caesar Wang
2015-11-06  9:50     ` Zain
2015-11-06 10:12   ` Heiko Stuebner
2015-11-06 10:27     ` Zain [this message]
2015-11-06  1:17 ` [PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation Zain Wang
2015-11-06  2:27   ` Rob Herring
2015-11-06  9:00   ` Heiko Stuebner
2015-11-06  9:36     ` Zain
2015-11-06  1:36 ` [PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288 Caesar Wang
2015-11-06  9:53   ` Zain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C8095.30905@rock-chips.com \
    --to=zain.wang@rock-chips.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eddie.cai@rock-chips.com \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hl@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zhengsq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox