From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161338AbbKFMz5 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Nov 2015 07:55:57 -0500
Received: from mout.web.de ([212.227.17.11]:61456 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932747AbbKFMzz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Nov 2015 07:55:55 -0500
Subject: Re: GPU-DRM-i915: Delete an unnecessary check before the function
 call "pwm_put"
To: Jani Nikula <jani.nikula@linux.intel.com>,
        Daniel Vetter <daniel.vetter@intel.com>,
        David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
References: <5307CAA2.8060406@users.sourceforge.net>
 <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
 <530A086E.8010901@users.sourceforge.net>
 <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
 <530A72AA.3000601@users.sourceforge.net>
 <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
 <530B5FB6.6010207@users.sourceforge.net>
 <alpine.DEB.2.10.1402241710370.2074@hadrien>
 <530C5E18.1020800@users.sourceforge.net>
 <alpine.DEB.2.10.1402251014170.2080@hadrien>
 <530CD2C4.4050903@users.sourceforge.net>
 <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <563CA07D.30805@users.sourceforge.net>
 <87h9kzl27o.fsf@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <563CA349.7030004@users.sourceforge.net>
Date: Fri, 6 Nov 2015 13:55:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <87h9kzl27o.fsf@intel.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:1Z7AVXEFUZgYVtrId3e6/OmDTz6ItrfDw7XLu9Rk2G2eSrtjkEI
 QvanP4YcHBuzUXIOVQr1Lrk3spz/hoFiW/dZ1SuAumuSr86PJOTPHDQ2iKy5ElHEUpOUNMS
 mSomqZzG1lbJdS2vmTrZsmhkzYbMU17ZUrI0CM4Pbtazhbxxk7EqM9NQ59WJrV3zvmRtmbN
 5ho2SRaPMK90Joa9mWn5w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4vRm7fE8avI=:G1Q9PZ8BBjfD8X6eZZP2Zt
 ILoNA/BL2Pc+3fwdEJ4/NQZuRulvkeSv5e522LFqGnyANdKHZ1TvcC/yvq+1uVemnlv7P2Yh+
 8Smx5loQslJUKveKHojWlUF7FAQnKkWP1SuLE9HM5QxPCzfxnyOJwrIRJk0D/92yqswYVp3du
 PyeTB4dt946j2nI3pVS8AyJNhTJL3kL7wcRigpucu33XnTRSGqlTOSeDSZKcI5Na/yqtxIXhb
 Zu2cYmLxH7PWMJBdhmv5NtM5fTB77T4aehmpIctO+qnMJY/Zu8CGNe2Y4KFdcoLNeeMG8L2g2
 kGRUfOkuyWmubyJJj7sS7Dapsgm+J6ZZwRfiOtBymjK2Cq4zaFYNAI+iIhhXpYyHC3TGrfJdb
 vFuU+E/ijJgSlEHhpAU5Fua4oFpigGyI1rTy8kNQh2lxIReS0cZwe51PPt5csAC5BtN8B31AL
 M9AAh1Ya60EXoBORJyWxSBQ+fNMae2rYiRbnS93Q1UM1yZXVKX686ridHJO4EycfC7kk0rS/f
 jnLSGo28sYlViWMJu1PuCRTtLzk4LVTTgbZ5k56vf0yB57aGfUSXZ9M8e+AXVB7hDOiL1k2Ei
 IrG7NQrHtgaOby3Ae0TSHyeYc0fOInM2Id/XO2sGgsCRHnXSrGk0L7AxHxLuEVmRSRCg0EmQK
 yH30GCTxXEelQdk+Vjfnvau45X9gepCrgkHbRGLwTf1+CK3vaazivKMVghOo5gwdOPmMcBa37
 miM3+JoTDFX9OVvlaZGB7EEp6wAOPlI090e2yvE84TNgG7ihqtHHx8fvhZ9VSRGJkBesCgSEk
 0Wbwuhm
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> The pwm_put() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
> 
> The compiler doesn't need it, but IMO it's useful documentation for humans.

How do you think about to extend the explicit documentation for
the affected parameters in the Linux programming interfaces?

Regards,
Markus