From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034018AbbKFXTE (ORCPT ); Fri, 6 Nov 2015 18:19:04 -0500 Received: from mga09.intel.com ([134.134.136.24]:27255 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757627AbbKFXTC (ORCPT ); Fri, 6 Nov 2015 18:19:02 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,254,1444719600"; d="scan'208";a="813792116" Subject: Re: [PATCH] Intel device IDs for PCH To: Andy Shevchenko References: <1446578748-13965-1-git-send-email-alexandra.yates@linux.intel.com> Cc: ptyser@xes-inc.com, Samuel Ortiz , Lee Jones , "linux-kernel@vger.kernel.org" From: Alexandra Yates Message-ID: <563D360F.5010600@linux.intel.com> Date: Fri, 6 Nov 2015 15:21:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On 11/06/2015 10:44 AM, Andy Shevchenko wrote: > On Tue, Nov 3, 2015 at 9:25 PM, Alexandra Yates > wrote: >> Adding Intel codename Lewisburg platform device IDs for PCH. >> >> Signed-off-by: Alexandra Yates >> --- >> drivers/mfd/lpc_ich.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c >> index c5a9a08..d9904ac6 100644 >> --- a/drivers/mfd/lpc_ich.c >> +++ b/drivers/mfd/lpc_ich.c >> @@ -55,6 +55,7 @@ >> * document number TBD : Coleto Creek >> * document number TBD : Wildcat Point-LP >> * document number TBD : 9 Series >> + * document number TBD : Lewisburg >> */ >> >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> @@ -219,6 +220,7 @@ enum lpc_chipsets { >> LPC_COLETO, /* Coleto Creek */ >> LPC_WPT_LP, /* Wildcat Point-LP */ >> LPC_BRASWELL, /* Braswell SoC */ >> + LPC_LEWISBURG, /* Lewisburg */ >> LPC_9S, /* 9 Series */ >> }; >> >> @@ -527,6 +529,10 @@ static struct lpc_ich_info lpc_chipset_info[] = { >> .name = "Braswell SoC", >> .iTCO_version = 3, >> }, >> + [LPC_LEWISBURG] = { >> + .name = "Lewisburg", >> + .iTCO_version = 2, >> + }, >> [LPC_9S] = { >> .name = "9 Series", >> .iTCO_version = 2, >> @@ -541,6 +547,15 @@ static struct lpc_ich_info lpc_chipset_info[] = { >> */ >> static const struct pci_device_id lpc_ich_ids[] = { >> { PCI_VDEVICE(INTEL, 0x0f1c), LPC_BAYTRAIL}, >> + { PCI_VDEVICE(INTEL, 0xa242), LPC_LEWISBURG}, > > If you may notice the IDs are sorted by number. > >> + { PCI_VDEVICE(INTEL, 0xa243), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c1), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c2), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c3), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c4), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c5), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c6), LPC_LEWISBURG}, >> + { PCI_VDEVICE(INTEL, 0xa1c7), LPC_LEWISBURG}, >> { PCI_VDEVICE(INTEL, 0x1c41), LPC_CPT}, >> { PCI_VDEVICE(INTEL, 0x1c42), LPC_CPTD}, >> { PCI_VDEVICE(INTEL, 0x1c43), LPC_CPTM}, >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > Thank you for your review. I changed the order to match the series on the list. And sent V2 of the patch. -- Thank you,