From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757626AbbKFXyJ (ORCPT ); Fri, 6 Nov 2015 18:54:09 -0500 Received: from mga09.intel.com ([134.134.136.24]:21054 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838AbbKFXyG (ORCPT ); Fri, 6 Nov 2015 18:54:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,254,1444719600"; d="scan'208";a="844608563" Subject: Re: [PATCH] Intel device IDs SATA To: Andy Shevchenko References: <1446577791-3087-1-git-send-email-alexandra.yates@linux.intel.com> Cc: linux-ide@vger.kernel.org, Tejun Heo , "linux-kernel@vger.kernel.org" From: Alexandra Yates Message-ID: <563D3E46.6020708@linux.intel.com> Date: Fri, 6 Nov 2015 15:56:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On 11/06/2015 10:42 AM, Andy Shevchenko wrote: > On Tue, Nov 3, 2015 at 9:09 PM, Alexandra Yates > wrote: >> Adding Intel codename Lewisburg platform device IDs for SATA. >> >> Signed-off-by: Alexandra Yates >> --- >> drivers/ata/ahci.c | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c >> index a466602..8c7a04a 100644 >> --- a/drivers/ata/ahci.c >> +++ b/drivers/ata/ahci.c >> @@ -68,6 +68,7 @@ enum board_ids { >> board_ahci_yes_fbs, >> >> /* board IDs for specific chipsets in alphabetical order */ >> + board_ahci_lbg, >> board_ahci_avn, >> board_ahci_mcp65, >> board_ahci_mcp77, >> @@ -161,6 +162,13 @@ static const struct ata_port_info ahci_port_info[] = { >> .port_ops = &ahci_ops, >> }, >> /* by chipsets */ >> + [board_ahci_lbg] = { >> + .flags = AHCI_FLAG_COMMON, >> + .pio_mask = ATA_PIO4, >> + .udma_mask = ATA_UDMA6, >> + .port_ops = &ahci_ops, >> + }, >> + >> [board_ahci_avn] = { >> .flags = AHCI_FLAG_COMMON, >> .pio_mask = ATA_PIO4, >> @@ -314,6 +322,16 @@ static const struct pci_device_id ahci_pci_tbl[] = { >> { PCI_VDEVICE(INTEL, 0x1f37), board_ahci_avn }, /* Avoton RAID */ >> { PCI_VDEVICE(INTEL, 0x1f3e), board_ahci_avn }, /* Avoton RAID */ >> { PCI_VDEVICE(INTEL, 0x1f3f), board_ahci_avn }, /* Avoton RAID */ >> + { PCI_VDEVICE(INTEL, 0xa182), board_ahci_lbg }, /* Lewisburg AHCI*/ >> + { PCI_VDEVICE(INTEL, 0xa202), board_ahci_lbg }, /* Lewisburg AHCI*/ >> + { PCI_VDEVICE(INTEL, 0xa184), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0xa204), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0xa186), board_ahci_lbg }, /* Lewisburg RAID*/ > > I think it makes sense to keep IDs ordered at least in range of one group Since this patch was already accepted I'm sending you a separate patch to correct the order as suggested by Andy. > >> + { PCI_VDEVICE(INTEL, 0xa206), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0x2822), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0x2826), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0xa18e), board_ahci_lbg }, /* Lewisburg RAID*/ >> + { PCI_VDEVICE(INTEL, 0xa20e), board_ahci_lbg }, /* Lewisburg RAID*/ >> { PCI_VDEVICE(INTEL, 0x2823), board_ahci }, /* Wellsburg RAID */ >> { PCI_VDEVICE(INTEL, 0x2827), board_ahci }, /* Wellsburg RAID */ >> { PCI_VDEVICE(INTEL, 0x8d02), board_ahci }, /* Wellsburg AHCI */ >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > -- Thank you,