Re: [PATCH V2] Staging: wilc1000: Fix build break due to undeclared *wilc and implicit declaration of init_irq

Dan Carpenter
2015-11-09T08:19:09Z

On Mon, Nov 09, 2015 at 05:02:48PM +0900, glen lee wrote:
> Hi Punit Vara,
>
> I cannot find build errors on my build machines.
>
> According the log which you have posted before says *wilc is undeclared in the function init_wilc_driver,
> which means WILC_SPI is selected because one of SPI or SDIO should be chosen at the moment.
> Hence, struct wilc *wilc should be compiled together.
> It looks like wilc1000 is compiled without SPI or SDIO.
>
> Of course, there are many cases that I don't know, so you could let me know the wilc1000 build configuration?
>
> static int __init init_wilc_driver(void)
> {
> #ifdef WILC_SPI

This should be #ifndef WILC_SDIO

> struct wilc *wilc;
> #endif

But the large question remains of why do we have this variable here any
way?

regards,
dan carpenter