From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752556AbbKIQzg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Nov 2015 11:55:36 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:23303 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752010AbbKIQzc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Nov 2015 11:55:32 -0500
Subject: Re: [PATCH v3 11/32] scsi: hisi_sas: add phy SAS ADDR initialization
To: Arnd Bergmann <arnd@arndb.de>
References: <1447086757-147706-1-git-send-email-john.garry@huawei.com>
 <1447086757-147706-12-git-send-email-john.garry@huawei.com>
 <4369607.QVA3rBnZUm@wuerfel>
CC: <JBottomley@odin.com>, <robh+dt@kernel.org>, <pawel.moll@arm.com>,
        <mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
        <galak@codeaurora.org>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linuxarm@huawei.com>, <john.garry2@mail.dcu.ie>, <hare@suse.de>,
        <xuwei5@hisilicon.com>, <zhangfei.gao@linaro.org>
From: John Garry <john.garry@huawei.com>
Message-ID: <5640CF00.2030003@huawei.com>
Date: Mon, 9 Nov 2015 16:51:12 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <4369607.QVA3rBnZUm@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.202.137.251]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090201.5640CF16.00DF,ss=1,re=0.000,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2011-05-27 18:58:46
X-Mirapoint-Loop-Id: bc97ac1e6e6cd1ea399ba647b48aa0e6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/11/2015 16:28, Arnd Bergmann wrote:
> On Tuesday 10 November 2015 00:32:16 John Garry wrote:
>>   }
>>
>> +static void hisi_sas_init_add(struct hisi_hba *hisi_hba)
>> +{
>> +       int i;
>> +
>> +       for (i = 0; i < hisi_hba->n_phy; i++)
>> +               memcpy(&hisi_hba->phy[i].dev_sas_addr,
>> +                      hisi_hba->sas_addr,
>> +                      SAS_ADDR_SIZE);
>> +}
>
> I don't know the background here, but I thought it would have to
> be a different address on each phy. Are you sure this is not the
> case?
>
> 	Arnd
>
> .
>

Hi,

Each controller should have a unique SAS addr but not each phy.

Regards,
john