Re: [PATCH 00/26] Consolidate patches and add support for new devices

Linus Walleij
2015-11-09T12:49:15Z

On Fri, Nov 6, 2015 at 12:34 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> NOTE: This patch set applies to synaptics-rmi4 branch in
> Dmitry Torokhov's input tree.
(...)
> This patchset applies cleanly to the synaptics-rmi4 branch, but does not
> successfully build because the synaptics-rmi4 branch is based on the 3.14
(...)
> I would suggest updating the synaptics-rmi4 branch to something
> more resent.

I suggest we stop seeing Dmitry's branch as "master" for RMI4 development.
Instead work on the v4.3-rc6-based branch you have at
https://github.com/aduggan/linux.git, and then (after the merge window)
rebase it to v4.4-rc1 and ask Dmitry to *drop* this old branch and pull in
your stuff instead, and then look at the end result of that.

Who knows, maybe he thinks it's clean enough to go into v4.5.
Or for parts of it to go into v4.5.

In any case, surely he's more helped by an up-to-date rebased branch
than having to rebase it himself too.

> This patch set consolidates some outstanding patches and then builds on
> that to add support for new devices.

Unless Dmitry is extremely interested in the development history,
I suggest to squash the whole thing down to a few patches that
begins by adding the bus and infrastructure and then one function per
patch.

> I also have some additional patches which convert hid-rmi
> into a transport driver for rmi_core. I held off submitting since 3.14
> doesn't contain hid-rmi.

Another reason for us to reboot development based on *your*
branch.

I'll go over and review the patches though!

Yours,
Linus Walleij