From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbKJDtX (ORCPT ); Mon, 9 Nov 2015 22:49:23 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:25639 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbbKJDtV (ORCPT ); Mon, 9 Nov 2015 22:49:21 -0500 Subject: Re: [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove To: John Garry References: <1447086757-147706-1-git-send-email-john.garry@huawei.com> <1447086757-147706-9-git-send-email-john.garry@huawei.com> CC: , , , , , , , , , , , , , From: Wei Fang Message-ID: <5641690E.10303@huawei.com> Date: Tue, 10 Nov 2015 11:48:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1447086757-147706-9-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.236.214] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5641691F.011E,ss=1,re=0.000,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2011-05-27 18:58:46 X-Mirapoint-Loop-Id: 18b081b1988ce874cbdccf00c6658d66 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 2015/11/10 0:32, John Garry wrote: > This patch also includes relevant memory/pool > free'ing and sas/scsi host removal > > Signed-off-by: John Garry > --- > drivers/scsi/hisi_sas/hisi_sas_main.c | 71 ++++++++++++++++++++++++++++++++++- > 1 file changed, 70 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c > index 97f5368..7f81000 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_main.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c > @@ -126,6 +126,59 @@ err_out: > return -ENOMEM; > } > > +static void hisi_sas_free(struct hisi_hba *hisi_hba) > +{ > + struct device *dev = &hisi_hba->pdev->dev; > + int i, s; > + > + for (i = 0; i < hisi_hba->queue_count; i++) { > + s = sizeof(struct hisi_sas_cmd_hdr) * HISI_SAS_QUEUE_SLOTS; > + if (hisi_hba->cmd_hdr[i]) > + dma_free_coherent(dev, s, > + hisi_hba->cmd_hdr[i], > + hisi_hba->cmd_hdr_dma[i]); > + > + s = hisi_hba->hw->complete_hdr_size * HISI_SAS_QUEUE_SLOTS; > + if (hisi_hba->complete_hdr[i]) > + dma_free_coherent(dev, s, > + hisi_hba->complete_hdr[i], > + hisi_hba->complete_hdr_dma[i]); > + } > + > + dma_pool_destroy(hisi_hba->status_buffer_pool); > + dma_pool_destroy(hisi_hba->command_table_pool); > + dma_pool_destroy(hisi_hba->sge_page_pool); > + > + s = HISI_SAS_MAX_ITCT_ENTRIES * sizeof(struct hisi_sas_itct); > + if (hisi_hba->itct) > + dma_free_coherent(dev, s, > + hisi_hba->itct, hisi_hba->itct_dma); > + > + s = HISI_SAS_COMMAND_ENTRIES * sizeof(struct hisi_sas_iost); > + if (hisi_hba->iost) > + dma_free_coherent(dev, s, > + hisi_hba->iost, hisi_hba->iost_dma); > + > + s = HISI_SAS_COMMAND_ENTRIES * sizeof(struct hisi_sas_breakpoint); > + if (hisi_hba->breakpoint) > + dma_free_coherent(dev, s, > + hisi_hba->breakpoint, > + hisi_hba->breakpoint_dma); > + > + > + s = sizeof(struct hisi_sas_initial_fis) * HISI_SAS_MAX_PHYS; > + if (hisi_hba->initial_fis) > + dma_free_coherent(dev, s, > + hisi_hba->initial_fis, > + hisi_hba->initial_fis_dma); > + > + s = HISI_SAS_COMMAND_ENTRIES * sizeof(struct hisi_sas_breakpoint) * 2; > + if (hisi_hba->sata_breakpoint) > + dma_free_coherent(dev, s, > + hisi_hba->sata_breakpoint, > + hisi_hba->sata_breakpoint_dma); > + > +} > > static struct Scsi_Host *hisi_sas_shost_alloc(struct platform_device *pdev, > const struct hisi_sas_hw *hw) > @@ -188,8 +241,10 @@ static struct Scsi_Host *hisi_sas_shost_alloc(struct platform_device *pdev, > if (IS_ERR(hisi_hba->ctrl)) > goto err_out; > > - if (hisi_sas_alloc(hisi_hba, shost)) > + if (hisi_sas_alloc(hisi_hba, shost)) { > + hisi_sas_free(hisi_hba); > goto err_out; > + } > > return shost; > err_out: > @@ -270,6 +325,20 @@ err_out_ha: > } > EXPORT_SYMBOL_GPL(hisi_sas_probe); > > +int hisi_sas_remove(struct platform_device *pdev) > +{ > + struct sas_ha_struct *sha = platform_get_drvdata(pdev); > + struct hisi_hba *hisi_hba = sha->lldd_ha; > + > + sas_unregister_ha(sha); > + sas_remove_host(sha->core.shost); > + scsi_remove_host(sha->core.shost); scsi host should be removed before detaching SAS transport. See more information: http://www.spinics.net/lists/linux-scsi/msg90088.html Thanks, Wei > + hisi_sas_free(hisi_hba); > + return 0; > +} > +EXPORT_SYMBOL_GPL(hisi_sas_remove); > + > static __init int hisi_sas_init(void) > { > pr_info("hisi_sas: driver version %s\n", DRV_VERSION); >