From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: gleb@kernel.org, pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, cornelia.huck@de.ibm.com
Subject: Re: [PATCH V6 0/6] Fast mmio eventfd fixes
Date: Tue, 10 Nov 2015 14:25:26 +0800 [thread overview]
Message-ID: <56418DD6.4060608@redhat.com> (raw)
In-Reply-To: <20151109221825-mutt-send-email-mst@redhat.com>
On 11/10/2015 04:19 AM, Michael S. Tsirkin wrote:
> On Mon, Nov 09, 2015 at 12:35:45PM +0800, Jason Wang wrote:
>> >
>> >
>> > On 11/09/2015 01:11 AM, Michael S. Tsirkin wrote:
>>> > > On Tue, Sep 15, 2015 at 02:41:53PM +0800, Jason Wang wrote:
>>>> > >> Hi:
>>>> > >>
>>>> > >> This series fixes two issues of fast mmio eventfd:
>>>> > >>
>>>> > >> 1) A single iodev instance were registerd on two buses: KVM_MMIO_BUS
>>>> > >> and KVM_FAST_MMIO_BUS. This will cause double in
>>>> > >> ioeventfd_destructor()
>>>> > >> 2) A zero length iodev on KVM_MMIO_BUS will never be found but
>>>> > >> kvm_io_bus_cmp(). This will lead e.g the eventfd will be trapped by
>>>> > >> qemu instead of host.
>>>> > >>
>>>> > >> 1 is fixed by allocating two instances of iodev and introduce a new
>>>> > >> capability for userspace. 2 is fixed by ignore the actual length if
>>>> > >> the length of iodev is zero in kvm_io_bus_cmp().
>>>> > >>
>>>> > >> Please review.
>>>> > >> Changes from V5:
>>>> > >> - move patch of explicitly checking for KVM_MMIO_BUS to patch 1 and
>>>> > >> remove the unnecessary checks
>>>> > >> - even more grammar and typo fixes
>>>> > >> - rabase to kvm.git
>>>> > >> - document KVM_CAP_FAST_MMIO
>>> > > What's up with userspace using this capability?
>> >
>> > It was renamed to KVM_CAP_IOEVENTFD_ANY_LENGTH.
>> >
>>> > > Did patches ever get posted?
>> >
>> > See https://lkml.org/lkml/2015/9/28/208
> Talking about userspace here.
> QEMU freeze is approaching, it really should
> use this to avoid regressions.
>
The patches were posted at
http://lists.gnu.org/archive/html/qemu-devel/2015-11/msg01276.html
(you were in cc list)
prev parent reply other threads:[~2015-11-10 6:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 6:41 [PATCH V6 0/6] Fast mmio eventfd fixes Jason Wang
2015-09-15 6:41 ` [PATCH V6 1/6] kvm: don't try to register to KVM_FAST_MMIO_BUS for non mmio eventfd Jason Wang
2015-09-15 7:05 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 2/6] kvm: factor out core eventfd assign/deassign logic Jason Wang
2015-09-15 7:07 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 3/6] kvm: fix double free for fast mmio eventfd Jason Wang
2015-09-15 7:13 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 4/6] kvm: fix zero length mmio searching Jason Wang
2015-09-15 7:52 ` Cornelia Huck
2015-09-15 6:41 ` [PATCH V6 5/6] kvm: add tracepoint for fast mmio Jason Wang
2015-09-15 6:41 ` [PATCH V6 6/6] kvm: add fast mmio capabilitiy Jason Wang
2015-09-15 15:07 ` Paolo Bonzini
2015-09-15 16:13 ` Cornelia Huck
2015-09-15 16:29 ` Paolo Bonzini
2015-09-15 16:44 ` Cornelia Huck
2015-09-15 16:47 ` Paolo Bonzini
2015-09-15 15:08 ` [PATCH V6 0/6] Fast mmio eventfd fixes Paolo Bonzini
2015-09-15 19:26 ` Michael S. Tsirkin
2015-09-16 8:11 ` Paolo Bonzini
2015-11-08 17:11 ` Michael S. Tsirkin
2015-11-09 4:35 ` Jason Wang
2015-11-09 20:19 ` Michael S. Tsirkin
2015-11-10 6:25 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56418DD6.4060608@redhat.com \
--to=jasowang@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox