From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbbKJHPp (ORCPT ); Tue, 10 Nov 2015 02:15:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:42453 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbbKJHPn (ORCPT ); Tue, 10 Nov 2015 02:15:43 -0500 Message-ID: <56419999.3020809@suse.de> Date: Tue, 10 Nov 2015 08:15:37 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: John Garry , JBottomley@odin.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, arnd@arndb.de CC: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linuxarm@huawei.com, john.garry2@mail.dcu.ie, xuwei5@hisilicon.com, zhangfei.gao@linaro.org Subject: Re: [PATCH v3 00/32] HiSilicon SAS driver References: <1447086757-147706-1-git-send-email-john.garry@huawei.com> In-Reply-To: <1447086757-147706-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2015 05:32 PM, John Garry wrote: > This is the driver patchset for the HiSilicon SAS driver. The driver > is a platform driver. > > The driver will support multiple revisions of HW. Currently only "v1" > HW is supported. > > The driver uses libsas framework within the SCSI framework. > > The v1 HW supports SSP and SMP, but not STP/SATA. > > Differences to v2: > - update device tree bindings > - remove while loops when evaluating hba struct > - remove _lo and _hi DMA struct fields > - revised spinlock usage > - fix error handling for when CMPLT_HDR_ERR_RCRD_XFRD set > - general coding style and cosmetic fixes > > Differences to v1: > - re-arch driver into main module and hw-specific driver module > - allocate hisi_hba in scsi_host_alloc > - use of_irq_count get irq count - depends on [1] > - use syscon to handle ctrl reg access > - get SAS address from device tree > - do not set cmd_per_lun to 1 > - remove remove controller id > - use static wq in phy struct > - process control phy in caller context > - fix port->port_attached issue for rmmod > > [1] http://www.spinics.net/lists/arm-kernel/msg452833.html > Nice work. Reviewed-by: Hannes Reinecke Although it should be dead trivial to convert the driver to use scsi-mq; but that can come in with a later patch. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)