From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751856AbbKJJWo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Nov 2015 04:22:44 -0500
Received: from mail-lb0-f194.google.com ([209.85.217.194]:36318 "EHLO
	mail-lb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751279AbbKJJWl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Nov 2015 04:22:41 -0500
Subject: Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types
 changed in _rtl88e_write_fw function
To: Andy Shevchenko <andy.shevchenko@gmail.com>
References: <20151108063725.GA1073@alpha.sfu-kras.ru>
 <CAHp75VdT3eiEeZWWkA6bVP8ABPhypLRUPkcdu8ThE5kBPeK2JA@mail.gmail.com>
 <563F315B.2020609@gmail.com>
 <CAHp75VcbJpQSbC8Gjzp-YW0MBYVXVUZiv=H0fX+0=usAD4wGQQ@mail.gmail.com>
Cc: devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vaishali Thakkar <vthakkar1994@gmail.com>,
        Jakub Sitnicki <jsitnicki@gmail.com>, Anish Bhatt <anish@gatech.edu>,
        Joe Perches <joe@perches.com>, Nicholas Mc Guire <der.herr@hofr.at>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        =?UTF-8?Q?R=c3=a9my_Oudompheng?= <remyoudompheng@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Shraddha Barke <shraddha.6596@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Ivan Safonov <insafonov@gmail.com>
Message-ID: <5641B7C8.8070704@gmail.com>
Date: Tue, 10 Nov 2015 16:24:24 +0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VcbJpQSbC8Gjzp-YW0MBYVXVUZiv=H0fX+0=usAD4wGQQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/09/2015 03:24 AM, Andy Shevchenko wrote:
> On Sun, Nov 8, 2015 at 1:26 PM, Ivan Safonov <insafonov@gmail.com> wrote:
>> On 11/08/2015 05:11 PM, Andy Shevchenko wrote:
>>> On Sun, Nov 8, 2015 at 8:37 AM, Ivan Safonov <insafonov@gmail.com> wrote:
>>>> Ideally the function should not change the variables outside of its body.
>>>> -static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen)
>>>> +static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
>>>>    {
>>>>           u32 i;
>>>>
>>>> -       for (i = *pfwlen; i < roundup(*pfwlen, 4); i++)
>>>> +       for (i = pfwlen; i < roundup(pfwlen, 4); i++)
>>>>                   pfwbuf[i] = 0;
>>> memset() ?
>>>
>>>> -       *pfwlen = i;
>>>> +       return i;
>>>>    }
>>>>
>>>>    static void _rtl88e_fw_page_write(struct adapter *adapt,
>>>> @@ -103,7 +103,7 @@ static void _rtl88e_write_fw(struct adapter *adapt,
>>>> u8 *buffer, u32 size)
>>>>           u32 page_no, remain;
>>>>           u32 page, offset;
>>>>
>>>> -       _rtl88e_fill_dummy(buf_ptr, &size);
>>>> +       size = _rtl88e_fill_dummy(buf_ptr, size);
>
>> memset applied in another patch. Here only replacement of the function type.
> Since it's used only once it would be nice to replace it by plain
> memset() in one patch.
>

I doubt its usefulness.
Perhaps, this function is not needed because firmware copied byte by byte.
It is function for firmware uploading (I don't know why it is so 
written, but in the case of the size of the firmware a multiple of 4, it 
can be easier):
static void _rtl88e_fw_block_write(struct adapter *adapt,
                    const u8 *buffer, u32 size)
{
     u32 blk_sz = sizeof(u32);
     const u8 *byte_buffer;
     const u32 *dword_buffer = (u32 *)buffer;
     u32 i, write_address, blk_cnt, remain;

     blk_cnt = size / blk_sz;
     remain = size % blk_sz;

     write_address = FW_8192C_START_ADDRESS;

     for (i = 0; i < blk_cnt; i++, write_address += blk_sz)
         usb_write32(adapt, write_address, dword_buffer[i]);

     byte_buffer = buffer + blk_cnt * blk_sz;
     for (i = 0; i < remain; i++, write_address++)
         usb_write8(adapt, write_address, byte_buffer[i]);
}