From: Jon Hunter <jonathanh@nvidia.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
Vinod Koul <vinod.koul@intel.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/6] dmaengine: tegra-apb: Only save channel state for those in use
Date: Tue, 10 Nov 2015 09:57:35 +0000 [thread overview]
Message-ID: <5641BF8F.1010304@nvidia.com> (raw)
In-Reply-To: <CAHp75Ve77TVmc6TE-mDRvH3_jbKZvzYv0dj7WOXF0mRFa=JErg@mail.gmail.com>
On 09/11/15 13:58, Andy Shevchenko wrote:
> On Mon, Nov 9, 2015 at 3:23 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
>> Currently the tegra-apb DMA driver suspend/resume helpers, save and
>> restore the registers for all channels regardless of whether they are
>> in use or not. Change this so that only channels that have been
>> allocated and configured are saved and restored.
>
> Nitpick
>
>> + /*
>> + * Only save the state of DMA channels that are in use.
>> + */
>
> One line?
>
>> + /*
>> + * Only restore the state of DMA channels that are in use.
>> + */
>
> Same.
Ok.
Jon
next prev parent reply other threads:[~2015-11-10 9:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 13:23 [PATCH V2 0/6] DMA: tegra-apb: Clean-up Jon Hunter
2015-11-09 13:23 ` [PATCH V2 1/6] dmaengine: tegra-apb: Correct runtime-pm usage Jon Hunter
2015-11-09 13:57 ` Andy Shevchenko
2015-11-10 9:57 ` Jon Hunter
2015-11-09 13:23 ` [PATCH V2 2/6] dmaengine: tegra-apb: Use dev_get_drvdata() Jon Hunter
2015-11-09 13:23 ` [PATCH V2 3/6] dmaengine: tegra-apb: Save and restore word count Jon Hunter
2015-11-09 13:23 ` [PATCH V2 4/6] dmaengine: tegra-apb: Only save channel state for those in use Jon Hunter
2015-11-09 13:58 ` Andy Shevchenko
2015-11-10 9:57 ` Jon Hunter [this message]
2015-11-09 13:23 ` [PATCH V2 5/6] dmaengine: tegra-apb: Update driver to use GFP_NOWAIT Jon Hunter
2015-11-09 13:23 ` [PATCH V2 6/6] dmaengine: tegra-apb: Free interrupts before killing tasklets Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5641BF8F.1010304@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox