public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix alloc_node_mem_map() to work on ia64 again
@ 2015-11-10 18:09 Tony Luck
  0 siblings, 0 replies; only message in thread
From: Tony Luck @ 2015-11-10 18:09 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: linux-kernel, Laura Abbott, Srinivas Kandagatla, Vlastimil Babka,
	Bjorn Andersson, Andrew Morton

In commit a1c34a3bf00af2cede839879502e12dc68491ad5
   "mm: Don't offset memmap for flatmem"

Laura fixed a problem for Srinivas relating to the bottom 2MB of RAM
on an ARM IFC6410 board.

One small wrinkle on ia64 is that it allocates the node_mem_map
earlier in arch code, so it skips the block of code where "offset"
is initialized.

Move initialization of start and offset before the check for the
node_mem_map so that they will always be available in the latter
part of the function.

Tested-by: Laura Abbott <laura@labbott.name>
Fixes: a1c34a3bf00a (mm: Don't offset memmap for flatmem)
Signed-off-by: Tony Luck <tony.luck@intel.com>

---
 mm/page_alloc.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 208e4c7e771b..17a3c66639a9 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5266,6 +5266,7 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat)
 
 static void __init_refok alloc_node_mem_map(struct pglist_data *pgdat)
 {
+	unsigned long __maybe_unused start = 0;
 	unsigned long __maybe_unused offset = 0;
 
 	/* Skip empty nodes */
@@ -5273,9 +5274,11 @@ static void __init_refok alloc_node_mem_map(struct pglist_data *pgdat)
 		return;
 
 #ifdef CONFIG_FLAT_NODE_MEM_MAP
+	start = pgdat->node_start_pfn & ~(MAX_ORDER_NR_PAGES - 1);
+	offset = pgdat->node_start_pfn - start;
 	/* ia64 gets its own node_mem_map, before this, without bootmem */
 	if (!pgdat->node_mem_map) {
-		unsigned long size, start, end;
+		unsigned long size, end;
 		struct page *map;
 
 		/*
@@ -5283,8 +5286,6 @@ static void __init_refok alloc_node_mem_map(struct pglist_data *pgdat)
 		 * aligned but the node_mem_map endpoints must be in order
 		 * for the buddy allocator to function correctly.
 		 */
-		start = pgdat->node_start_pfn & ~(MAX_ORDER_NR_PAGES - 1);
-		offset = pgdat->node_start_pfn - start;
 		end = pgdat_end_pfn(pgdat);
 		end = ALIGN(end, MAX_ORDER_NR_PAGES);
 		size =  (end - start) * sizeof(struct page);
-- 
2.1.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-11-10 18:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10 18:09 [PATCH] Fix alloc_node_mem_map() to work on ia64 again Tony Luck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox