From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbbKKBKe (ORCPT ); Tue, 10 Nov 2015 20:10:34 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:10658 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbbKKBKd (ORCPT ); Tue, 10 Nov 2015 20:10:33 -0500 Subject: Re: [PATCH 1/1] rtc: fix type information of rtc-proc To: Alessandro Zummo , Alexandre Belloni , rtc-linux , linux-kernel References: <1444297652-10328-1-git-send-email-thunder.leizhen@huawei.com> CC: Arnd Bergmann , Zefan Li , Xinwei Hu , Tianhong Ding , Hanjun Guo From: "Leizhen (ThunderTown)" Message-ID: <564294AB.1080500@huawei.com> Date: Wed, 11 Nov 2015 09:06:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1444297652-10328-1-git-send-email-thunder.leizhen@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.23.164] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.564294B4.00FC,ss=1,re=0.000,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2011-05-27 18:58:46 X-Mirapoint-Loop-Id: 02b9cf526a7cb1a3055cd43d445cccd4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, all I'm sorry. Maybe I didn't describe clearly enough before. These words are finally shown to the end user. The end user maybe not a programmer, abbreviation word is unsuitable. cat /proc/driver/rtc rtc_time : 00:47:43 rtc_date : 2015-11-11 alrm_time : 03:27:58 //alrm_time --> alarm_time alrm_date : 2015-10-08 //alrm_date --> alarm_date alarm_IRQ : no alrm_pending : no //alrm_pending --> alarm_pending update IRQ enabled : no On 2015/10/8 17:47, Zhen Lei wrote: > Display the whole word of "alarm", make it look more comfortable. > > Signed-off-by: Zhen Lei > --- > drivers/rtc/rtc-proc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-proc.c b/drivers/rtc/rtc-proc.c > index ffa69e1..ef83f34 100644 > --- a/drivers/rtc/rtc-proc.c > +++ b/drivers/rtc/rtc-proc.c > @@ -58,7 +58,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset) > > err = rtc_read_alarm(rtc, &alrm); > if (err == 0) { > - seq_printf(seq, "alrm_time\t: "); > + seq_printf(seq, "alarm_time\t: "); > if ((unsigned int)alrm.time.tm_hour <= 24) > seq_printf(seq, "%02d:", alrm.time.tm_hour); > else > @@ -72,7 +72,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset) > else > seq_printf(seq, "**\n"); > > - seq_printf(seq, "alrm_date\t: "); > + seq_printf(seq, "alarm_date\t: "); > if ((unsigned int)alrm.time.tm_year <= 200) > seq_printf(seq, "%04d-", alrm.time.tm_year + 1900); > else > @@ -87,7 +87,7 @@ static int rtc_proc_show(struct seq_file *seq, void *offset) > seq_printf(seq, "**\n"); > seq_printf(seq, "alarm_IRQ\t: %s\n", > alrm.enabled ? "yes" : "no"); > - seq_printf(seq, "alrm_pending\t: %s\n", > + seq_printf(seq, "alarm_pending\t: %s\n", > alrm.pending ? "yes" : "no"); > seq_printf(seq, "update IRQ enabled\t: %s\n", > (rtc->uie_rtctimer.enabled) ? "yes" : "no"); > -- > 2.5.0 > > > > . >