[PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

[PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

[Ivan Safonov]

_rtl88e_fill_dummy fills the array elemets with zeros if necessary.

Signed-off-by: Ivan Safonov <insafonov@gmail.com>
---
 drivers/staging/rtl8188eu/hal/fw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
index 1d8930a..7f1df4d 100644
--- a/drivers/staging/rtl8188eu/hal/fw.c
+++ b/drivers/staging/rtl8188eu/hal/fw.c
@@ -189,7 +189,7 @@ int rtl88eu_download_fw(struct adapter *adapt)
 		return -EFBIG;
 	}
 
-	pfwdata = kzalloc(FW_8188E_SIZE, GFP_KERNEL);
+	pfwdata = kmalloc(FW_8188E_SIZE, GFP_KERNEL);
 	if (!pfwdata)
 		return -ENOMEM;
 
-- 
2.4.10

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

[Dan Carpenter]

On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote:
> _rtl88e_fill_dummy fills the array elemets with zeros if necessary.
> 

_rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code
is aligned but it doesn't fill up to the end of FW_8188E_SIZE.  Why do
we even allocate that much memory.  Why don't we just allocate:

	pfwdata = kmalloc(round_up(fwsize, sizeof(u32)), GFP_KERNEL);

regards,
dan carpenter

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

[Ivan Safonov]

On 11/11/2015 04:43 PM, Dan Carpenter wrote:
> On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote:
>> _rtl88e_fill_dummy fills the array elemets with zeros if necessary.
>>
> _rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code
> is aligned but it doesn't fill up to the end of FW_8188E_SIZE.  Why do
> we even allocate that much memory.  Why don't we just allocate:
>
> 	pfwdata = kmalloc(round_up(fwsize, sizeof(u32)), GFP_KERNEL);
>
> regards,
> dan carpenter

Yes, it will save about 2 KB. I will correct it in the next patch.

Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

[Greg Kroah-Hartman]

On Wed, Nov 11, 2015 at 05:17:50PM +0700, Ivan Safonov wrote:
> On 11/11/2015 04:43 PM, Dan Carpenter wrote:
> >On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote:
> >>_rtl88e_fill_dummy fills the array elemets with zeros if necessary.
> >>
> >_rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code
> >is aligned but it doesn't fill up to the end of FW_8188E_SIZE.  Why do
> >we even allocate that much memory.  Why don't we just allocate:
> >
> >	pfwdata = kmalloc(round_up(fwsize, sizeof(u32)), GFP_KERNEL);
> >
> >regards,
> >dan carpenter
> 
> Yes, it will save about 2 KB. I will correct it in the next patch.

Please send a v3 series with this fixed up.

Also, please properly thread your patches so they all show up grouped
together.

thanks,

greg k-h