Re: [PATCH 1/3] iio: mma8452: add freefall detection for Freescale's accelerometers

[Lars-Peter Clausen <lars@metafoo.de>]

On 11/11/2015 07:38 PM, Martin Kepplinger wrote:
> This adds freefall event detection to the supported devices. It adds the 
> in_accel_x&y&z_mag_falling_en iio event attribute, which activates 
> freefall mode.
> 

Hi,

Thanks for the patch, looks pretty good. Just a few things.

> In freefall mode, the current acceleration values of all activated axis 
> are added and if the *sum* falls *under* the threshold specified

Are you sure its not the magnitude of the vector rather than the sum of the
individual components?

> (in_accel_mag_falling_value), the appropriate IIO event code is 
> generated.
[...]
> +enum { +	axis_x, +	axis_y, +	axis_z, +};

That should be part of patch two I guess.

[...]
> +static IIO_DEVICE_ATTR_NAMED(accel_xayaz_mag_falling_en, + 
> in_accel_x&y&z_mag_falling_en, +			     S_IRUGO | S_IWUSR, + 
> mma8452_get_freefall_mode, +			     mma8452_set_freefall_mode, + 0);

This should be created by the core based on the event spec, shouldn't it?