From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752592AbbKKTsK (ORCPT ); Wed, 11 Nov 2015 14:48:10 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34648 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbbKKTsH (ORCPT ); Wed, 11 Nov 2015 14:48:07 -0500 Subject: Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation. To: Andy Shevchenko , Dave Penkler References: <20151111110827.GA1785@slacky> <20151111111609.GA1875@slacky> Cc: Greg Kroah-Hartman , peter.chen@freescale.com, teuniz@gmail.com, USB , "linux-kernel@vger.kernel.org" , dpenkler@gmail.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56439B73.8070909@cogentembedded.com> Date: Wed, 11 Nov 2015 22:48:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 11/11/2015 10:03 PM, Andy Shevchenko wrote: >> Background: >> When performing a read on an instrument that is executing a function >> that runs longer than the USB timeout the instrument may hang and require >> a device reset to recover. The READ_STATUS_BYTE operation always returns >> even when the instrument is busy permitting to poll for the appropriate >> condition. This capability is refered to in instrument application notes Referred. >> on synchronizing acquisitions for other platforms. > > Won't comment precisely by line, but common nitpicks about style: > - added empty lines where no need > - redundant parens > - pieces of code takes whole line when they are quite fit tail of previous one. > > And why malloc for 8 bytes? To be able to do DMA with this buffer, apparently. >> Signed-off-by: Dave Penkler [patch skipped] It's a good tone to skip the parts you're not commenting on, so others wouldn't have to scroll in vain. WBR, Sergei