From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: kgene.kim@samsung.com, thomas.ab@samsung.com,
amitdanielk@gmail.com, olof@lixom.net, khilman@linaro.org,
arnd@arndb.de
Subject: Re: [PATCH v4 9/9] drivers: soc: Add support for Exynos PMU driver
Date: Thu, 12 Nov 2015 13:35:18 +0900 [thread overview]
Message-ID: <56441706.5070206@samsung.com> (raw)
In-Reply-To: <1447155784-12667-10-git-send-email-pankaj.dubey@samsung.com>
On 10.11.2015 20:43, Pankaj Dubey wrote:
> This patch moves Exynos PMU driver implementation from "arm/mach-exynos"
> to "drivers/soc/samsung". This driver is mainly used for setting misc
> bits of register from PMU IP of Exynos SoC which will be required to
> configure before Suspend/Resume. Currently all these settings are done
> in "arch/arm/mach-exynos/pmu.c" but moving ahead for ARM64 based SoC
> support, there is a need of this PMU driver in driver/* folder.
>
> This driver uses existing DT binding information and there should
> be no functionality change in the supported platforms.
>
> Signed-off-by: Amit Daniel Kachhap <amitdanielk@gmail.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> arch/arm/mach-exynos/Makefile | 4 +-
> arch/arm/mach-exynos/exynos-pmu.h | 45 ------
> arch/arm/mach-exynos/exynos3250-pmu.c | 175 ---------------------
> arch/arm/mach-exynos/exynos4-pmu.c | 223 ---------------------------
> arch/arm/mach-exynos/exynos5250-pmu.c | 196 ------------------------
> arch/arm/mach-exynos/exynos5420-pmu.c | 280 ----------------------------------
> arch/arm/mach-exynos/pmu.c | 183 ----------------------
> drivers/soc/samsung/Kconfig | 4 +
> drivers/soc/samsung/Makefile | 4 +
> drivers/soc/samsung/exynos-pmu.c | 183 ++++++++++++++++++++++
> drivers/soc/samsung/exynos-pmu.h | 45 ++++++
> drivers/soc/samsung/exynos3250-pmu.c | 175 +++++++++++++++++++++
> drivers/soc/samsung/exynos4-pmu.c | 223 +++++++++++++++++++++++++++
> drivers/soc/samsung/exynos5250-pmu.c | 196 ++++++++++++++++++++++++
> drivers/soc/samsung/exynos5420-pmu.c | 280 ++++++++++++++++++++++++++++++++++
> 16 files changed, 1112 insertions(+), 1105 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/exynos-pmu.h
> delete mode 100644 arch/arm/mach-exynos/exynos3250-pmu.c
> delete mode 100644 arch/arm/mach-exynos/exynos4-pmu.c
> delete mode 100644 arch/arm/mach-exynos/exynos5250-pmu.c
> delete mode 100644 arch/arm/mach-exynos/exynos5420-pmu.c
> delete mode 100644 arch/arm/mach-exynos/pmu.c
> create mode 100644 drivers/soc/samsung/exynos-pmu.c
> create mode 100644 drivers/soc/samsung/exynos-pmu.h
> create mode 100644 drivers/soc/samsung/exynos3250-pmu.c
> create mode 100644 drivers/soc/samsung/exynos4-pmu.c
> create mode 100644 drivers/soc/samsung/exynos5250-pmu.c
> create mode 100644 drivers/soc/samsung/exynos5420-pmu.c
Again - renames were not detected. This is strange... and actually
unreadable. The previous patch looked much better. What happened?
Please send also entire patchset to linux-pm mailing list. I asked about
it last time and can't see it as recipient here.
Best regards,
Krzysztof
prev parent reply other threads:[~2015-11-12 4:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 11:42 [PATCH v4 0/9] samsung: pmu: split up SoC specific PMU data Pankaj Dubey
2015-11-10 11:42 ` [PATCH v4 1/9] ARM: EXYNOS: removing redundant code from regs-pmu.h Pankaj Dubey
2015-11-10 11:42 ` [PATCH v4 2/9] ARM: EXYNOS: Fix potential NULL pointer access in exynos_sys_powerdown_conf Pankaj Dubey
2015-11-12 4:03 ` Krzysztof Kozlowski
2015-11-10 11:42 ` [PATCH v4 3/9] ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" Pankaj Dubey
2015-11-12 4:09 ` Krzysztof Kozlowski
2015-11-13 9:27 ` Pankaj Dubey
2015-11-10 11:42 ` [PATCH v4 4/9] ARM: EXYNOS: split up exynos3250 SoC specific PMU data Pankaj Dubey
2015-11-12 4:22 ` Krzysztof Kozlowski
2015-11-10 11:43 ` [PATCH v4 5/9] ARM: EXYNOS: split up exynos4 " Pankaj Dubey
2015-11-10 11:43 ` [PATCH v4 6/9] ARM: EXYNOS: split up exynos5250 " Pankaj Dubey
2015-11-10 11:43 ` [PATCH v4 7/9] ARM: EXYNOS: split up exynos5420 " Pankaj Dubey
2015-11-12 4:30 ` Krzysztof Kozlowski
2015-11-10 11:43 ` [PATCH v4 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver Pankaj Dubey
2015-11-12 4:39 ` Krzysztof Kozlowski
2015-11-10 11:43 ` [PATCH v4 9/9] drivers: soc: Add support for Exynos " Pankaj Dubey
2015-11-12 4:35 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56441706.5070206@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=amitdanielk@gmail.com \
--cc=arnd@arndb.de \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox