From: Marc Titinger <mtitinger@baylibre.com>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mturquette@baylibre.com, bcousson@baylibre.com,
ptitiano@baylibre.com
Subject: Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors
Date: Thu, 12 Nov 2015 10:38:13 +0100 [thread overview]
Message-ID: <56445E05.6070604@baylibre.com> (raw)
In-Reply-To: <CAEnQRZBeZpBxSCf85MRmByguHA8kXTNp9+NPD2d3cdsMRb+74w@mail.gmail.com>
On 11/11/2015 13:09, Daniel Baluta wrote:
> <snip>
>
>> Signed-off-by: Marc Titinger <mtitinger@baylibre.com>
>> ---
>> drivers/iio/adc/Kconfig | 9 +
>> drivers/iio/adc/Makefile | 1 +
>> drivers/iio/adc/ina2xx-iio.c | 404 +++++++++++++++++++++++++++++++++++++++++++
>
> One more thing. In IIO we do not prefer generic names for files.
> Lets name this after the first device in the family.
>
> Here I would say we should call it drivers/iio/adc/ina219.c. Skip the
> -iio suffix
> from file name, because it is already under the iio/ directory.
I get your point, but in this specific case there is already support for
this chip family in hwmon and both drivers make sense because both
applications exist (hardware monitoring or power measurement equipement).
To avoid confusion it may be good to have at least a common radix for
the CONFIG option, so that searching returns both options.
>
> If there is a module name conflict with hwmon module we can name the
> .ko resulted
> from this file ina219-iio.ko.
>
next prev parent reply other threads:[~2015-11-12 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 16:07 [RFC 0/4] IIO: add support for INA2xx power monitor Marc Titinger
2015-11-10 16:07 ` [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors Marc Titinger
2015-11-11 10:14 ` Daniel Baluta
2015-11-12 9:25 ` Marc Titinger
2015-11-11 12:09 ` Daniel Baluta
2015-11-12 9:38 ` Marc Titinger [this message]
2015-11-12 12:57 ` [RFC v2 1/2] " Marc Titinger
2015-11-14 18:59 ` Jonathan Cameron
2015-11-16 9:31 ` Marc Titinger
2015-11-16 17:27 ` Jonathan Cameron
2015-11-12 12:57 ` [RFC v2 2/2] iio: ina2xx: add SOFTWARE buffer mode using an iio kfifo Marc Titinger
2015-11-10 16:07 ` [RFC 2/4] iio: ina2xx: add SAMP_FREQ attribute Marc Titinger
2015-11-11 10:17 ` Daniel Baluta
2015-11-10 16:07 ` [RFC 3/4] iio: ina2xx: add debugfs reg access Marc Titinger
2015-11-10 16:07 ` [RFC 4/4] iio: ina2xx: add SOFTWARE buffer mode using an iio kfifo Marc Titinger
2015-11-10 18:23 ` Lars-Peter Clausen
2015-11-12 10:18 ` Marc Titinger
2015-11-12 10:20 ` Lars-Peter Clausen
2015-11-14 18:44 ` Jonathan Cameron
2015-11-16 9:37 ` Marc Titinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56445E05.6070604@baylibre.com \
--to=mtitinger@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=daniel.baluta@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pmeerw@pmeerw.net \
--cc=ptitiano@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox