From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567AbbKLM2V (ORCPT ); Thu, 12 Nov 2015 07:28:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51869 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332AbbKLM2U (ORCPT ); Thu, 12 Nov 2015 07:28:20 -0500 Subject: Re: Shut up unhandled MSR warnings To: Borislav Petkov References: <20151112101317.GA3649@pd.tnic> <56446AFD.4030800@redhat.com> <20151112105958.GA3838@pd.tnic> <20151112121613.GC3838@pd.tnic> Cc: =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , kvm ML , lkml From: Paolo Bonzini Message-ID: <564485E0.9040902@redhat.com> Date: Thu, 12 Nov 2015 13:28:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151112121613.GC3838@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2015 13:16, Borislav Petkov wrote: >>> > > Yes, see guest_cpuid_has_* for an example of reading the CPUID values. >>> > > >>> > > But if it's defined for _all_ models starting at family 21, we can just >>> > > do it unconditionally. >> > >> > The thing is, those bits are Reserved again on the next family 22. Lemme >> > take a look at guest_cpuid_has_* and see how ugly it gets. > > Ok, I see there's guest_cpuid_is_amd() but I'd need also family and model. > > How about adding also > > guest_cpuid_family(), guest_cpuid_model(), guest_cpuid_stepping()? Those > could be quite useful in other contexts maybe. Sure, that's what I meant by "for an example". :) Paolo