Re: [PATCH 07/14] genirq: Add a new generic IPI reservation code to irq core

kbuild test robot
2015-11-03T12:07:44Z

[-- Attachment #1: Type: text/plain, Size: 3503 bytes --]

Hi Qais,

[auto build test ERROR on tip/irq/core -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url: https://github.com/0day-ci/linux/commits/Qais-Yousef/Implement-generic-IPI-support-mechanism/20151103-192028
config: mips-jz4740 (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips

All errors (new ones prefixed by >>):

kernel/irq/irqdomain.c: In function 'irq_reserve_ipi':
>> kernel/irq/irqdomain.c:890:9: error: implicit declaration of function '__irq_domain_alloc_irqs' [-Werror=implicit-function-declaration]
virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs, NUMA_NO_NODE,
^
kernel/irq/irqdomain.c: In function 'irq_destroy_ipi':
>> kernel/irq/irqdomain.c:950:2: error: implicit declaration of function 'irq_domain_free_irqs' [-Werror=implicit-function-declaration]
irq_domain_free_irqs(irq, nr_irqs);
^
cc1: some warnings being treated as errors

vim +/__irq_domain_alloc_irqs +890 kernel/irq/irqdomain.c

884 virq = irq_domain_alloc_descs(-1, nr_irqs, 0, NUMA_NO_NODE);
885 if (virq <= 0) {
886 pr_warn("Can't reserve IPI, failed to alloc descs\n");
887 return 0;
888 }
889
> 890 virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs, NUMA_NO_NODE,
891 (void *) dest, true);
892 if (virq <= 0) {
893 pr_warn("Can't reserve IPI, failed to alloc irqs\n");
894 goto free_descs;
895 }
896
897 for (i = virq; i < virq + nr_irqs; i++) {
898 data = irq_get_irq_data(i);
899 data->common->ipi_mask = ipi_mask_alloc(dest->nbits);
900 if (!data->common->ipi_mask)
901 goto free_ipi_mask;
902 ipi_mask_copy(data->common->ipi_mask, dest);
903 }
904
905 return virq;
906
907 free_ipi_mask:
908 for (i = virq; i < virq + nr_irqs; i++) {
909 data = irq_get_irq_data(i);
910 ipi_mask_free(data->common->ipi_mask);
911 }
912 free_descs:
913 irq_free_descs(virq, nr_irqs);
914 return 0;
915 }
916
917 /**
918 * irq_destroy_ipi() - unreserve an IPI that was previously allocated
919 * @irq: linux irq number to be destroyed
920 *
921 * Return the IPIs allocated with irq_reserve_ipi() to the system destroying all
922 * virqs associated with them.
923 */
924 void irq_destroy_ipi(unsigned int irq)
925 {
926 struct irq_data *data = irq_get_irq_data(irq);
927 struct irq_domain *domain;
928 unsigned int nr_irqs, i;
929
930 if (!irq || !data)
931 return;
932
933 domain = data->domain;
934 if (WARN_ON(domain == NULL))
935 return;
936
937 if (!irq_domain_is_ipi(domain)) {
938 pr_warn("Not an IPI domain!\n");
939 return;
940 }
941
942 nr_irqs = ipi_mask_weight(data->common->ipi_mask);
943 ipi_mask_free(data->common->ipi_mask);
944
945 for (i = irq + 1; i < irq + nr_irqs; i++) {
946 data = irq_get_irq_data(i);
947 ipi_mask_free(data->common->ipi_mask);
948 }
949
> 950 irq_domain_free_irqs(irq, nr_irqs);
951 }
952
953 #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 17582 bytes --]