From: "Lu, Baolu" <baolu.lu@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device
Date: Fri, 13 Nov 2015 09:31:14 +0800 [thread overview]
Message-ID: <56453D62.4030106@linux.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1511121118460.1321-100000@iolanthe.rowland.org>
On 11/13/2015 12:20 AM, Alan Stern wrote:
> On Thu, 12 Nov 2015, Lu Baolu wrote:
>
>> Commit 8306095fd2c1 ("USB: Disable USB 3.0 LPM in critical sections.")
>> adds usb3_lpm_enabled member to struct usb_device. There is no reference
>> to this member now. Hence, it could be removed.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Since patch 1/3 removes all the references to usb3_lpm_enabled, that
> patch should also remove the member itself. In other words, you might
> as well fold this patch into that one.
I was thinking that 1/3 is a fix patch. It could be back ported to
various kernels. If I merged this patch with 1/3, it might cause
problems, i.e. usb3_lpm_enabled is still used in that kernel.
Thanks,
-baolu
>
> Alan Stern
>
>
prev parent reply other threads:[~2015-11-13 1:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 2:19 [PATCH v2 0/3] usb: core: lpm: add sysfs node for usb3 lpm permit Lu Baolu
2015-11-12 2:19 ` [PATCH v2 1/3] usb: core: lpm: fix usb3_hardware_lpm sysfs node Lu Baolu
2015-11-12 16:20 ` Alan Stern
2015-11-13 5:55 ` Lu, Baolu
2015-11-13 15:28 ` Alan Stern
2015-11-14 7:18 ` Lu Baolu
2015-11-12 2:19 ` [PATCH v2 2/3] usb: core: lpm: add sysfs node for usb3 lpm permit Lu Baolu
2015-11-12 2:19 ` [PATCH v2 3/3] usb: core: lpm: remove usb3_lpm_enabled in usb_device Lu Baolu
2015-11-12 16:20 ` Alan Stern
2015-11-13 1:31 ` Lu, Baolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56453D62.4030106@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox